-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Discussion #33
Comments
How exactly do you plan to handle the non-free page? What exactly is the Date meant to represent? I thought it was the initial addition time, but that didn't make any sense. Is this the latest update of the software? If yes, explaining that at the start page would probably make sense. The Author Button (https://nodiscc.github.io/awesome-selfhosted-html-preview/#authors) downloads atm the Author File. O_O Can't clone the repo normally, thanks to https://github.com/awesome-selfhosted/awesome-selfhosted-data/blob/master/software/diaspora*.yml
|
The non-free page will only be rendered in the markdown-based list (there is a link to it in the header of https://nodiscc.github.io/awesome-selfhosted-html-preview). I don't want to mix Free/non-Free items, and the only way to keep them clearly separated with the way the HTML site is built, would essentially be to duplicate the site, or duplicate pages. The markdown version will keep being updated, so this information stays available, but non-Free software has never been a major focus for this project (the project description itself states so). It is listed as a convenience, at the request of a few contributors/users.
Yes. Looking at it now, I can see this is not very clear...
What about using a tooltip when hovering the mouse over this The tooltip would have the text
Thanks for noticing, I will have a solution soon.
Which OS? Is that on Windows? If so, as a workaround, you could try to change the value of your |
Ah, I completely missed that.
It seems like a promising suggestion, especially considering the existing system for Anti-features. Additionally, altering the text when it turns orange/red would help users comprehend the reason for the different colours. However, I'm slightly unsure about how many users will actually notice this change. Personally, while scrolling through the list, I wasn't aware that the anti-features tag had tooltips, as none of the other tags do. The idea of having tooltips for this specific tag didn't occur to me at the time.
Indeed, it is Windows. I came across the workaround you mentioned online, but I must admit I'm not fond of disabling this protection.
That would be nice. I comprehend that it's something that might happen again in the future, and if it does, we'll likely need to deal with it once more. From what I can tell, occurrences like this are relatively rare. |
Will be done later, the tooltip is sufficient for now.
fixed nodiscc/hecat@60760cd
fixed nodiscc/hecat@fefbd7c, 2322f5c -> preview updated https://nodiscc.github.io/awesome-selfhosted-html-preview/ |
Could you please take a moment to check whether PR #36 was created by me? I want to make sure I didn't misunderstand anything (and understand who that all should work). I got a little confused with the By the way, I must admit that creating a PR is much easier now. The provided template makes the process a lot smoother. 👍 |
- avoids filename issues on NTFS, consistent with automatic anchor generation - ref. awesome-selfhosted/awesome-selfhosted-data#33
Should be fixed in 59ed57f (https://github.com/nodiscc/hecat/releases/tag/1.0.1) + 30fa8ee (reimport data)
Look good, all syntax checks passing as well (https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5648100392/job/15299667081?pr=36)
It is shown in the template with the value Thanks |
Merged, should be built in a few moments (https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5648280194/job/15300165745) and pushed to https://github.com/nodiscc/awesome-selfhosted and https://nodiscc.github.io/awesome-selfhosted-html-preview/ |
After the next automatic metadata update tonight (https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/workflows/daily-update-metadata.yml), we should see the updated stars count/last update date on the HTML site (actually I think there is a small bug/corner case, and we won't - but let's check tomorrow) |
Works like a charm, thanks!
Looks also good, also good to know that everything was good in the PR itself.
😮 After implementing the last changes related to the Author File and other aspects, the website looks even better. I couldn't detect any other bugs. Again, you did an outstanding job! The only question I have is whether it was a deliberate decision to display |
Yes it was deliberate, it clearly shows that we are missing this information - it can still be added manually, or automation tools can be improved to retrieve it for non-Github projects. |
…ome-selfhosted-data - ref. awesome-selfhosted/awesome-selfhosted-data#33 - ref. awesome-selfhosted/awesome-selfhosted-data#11 - ref. #1038
…ome-selfhosted-data (#4083) - ref. awesome-selfhosted/awesome-selfhosted-data#33 - ref. awesome-selfhosted/awesome-selfhosted-data#11 - ref. #1038
https://awesome-selfhosted.net is now live. Please check the release announcement for more details. |
@nodiscc Congrats on the release of the Website and migration to the new repo. 🎉🎉 |
Also, if I spot it correctly, aren't we at the moment still missing the |
- these guidelines are only relevant for a small fraction of additions but would significantly increase the number of requirements in the pull request template, so add them in a separate document - move the guideline about providing a list of differences for forks to this document - ref. #33 (comment)
Proposed changes in #500
|
…nes (#500) * doc: contributing: add an 'other guidelines' section for soft guidelines - these guidelines are only relevant for a small fraction of additions but would significantly increase the number of requirements in the pull request template, so add them in a separate document - move the guideline about providing a list of differences for forks to this document - ref. #33 (comment) --------- Co-authored-by: Rabenherz112 <[email protected]>
Here is a draft for replying to such PRs. We should probably refine it a bit based on previous hand-crafted replies.
|
I agree with having reply templates for common problems. This wouldn't only speed up reviews but also ensure consistency across reviews from different people. But where should such templates be stored? Here is a Template that I think is good to use, if there is already a release, but it is not yet 4 months old (and it is a PR)
Also here is nodiscc template again, just raw for easier copy-paste (and some smaller tweaks, I did to it)
Other Ideas for template messages:
|
Been a while since I've done prs for this list due to other commitments but Im back now! I agree with the consistent messages, the only thing is that we can make sure is that they don't come across as to robotic and unapproachable. |
It is very kind of some people to monitor the availability of https://awesome-selfhosted.net/ for me, however please refrain to issue full
|
The VPS hosting https://awesome-selfhosted.net/ will undergo a maintenance/migration operation by the hosting provider (Ionos) somewhere between 15/04/2024 and 10/05/2024. The website will be unavailable during the maintenance. Further details/ETA will be provided when the maintenance is about to start. |
#837 (comment) |
Pull request merge can be slow sometimes. It seems that @nodiscc is the only maintainer at the moment. Is this correct? |
I found that Github has finally added a saved replies feature that can be used functionally via the slash command. This might be quite useful for a few of us (we no longer need to search the templates and copy and paste them into the review). When you go into your settings there is a new section named 'Saved replies' where you can add templates. Edit: |
I will definitely set this up, thank you raben! |
How do we handle software contributions that merely port an existing application to another system (e.g., Dockerization), especially when the repository is neither owned nor controlled by the original creator? I am asking because I just saw #1027 which kinda goes in that direction |
I don't think we should approve these, it will open the gates to a flood of custom builds, third-party docker images... a quick search returns at least 2 other docker image projects for Anki [1] [2], so I'd prefer if these solutions could be considered first:
I will have a look at #1027 |
Agreed
Agreed as well. Another potential issue is the risk of a bad actor cloning popular software, creating a Docker image, injecting malicious code, and submitting it to us. While unrelated to the mentioned PR, it's well-known that malicious Docker images for popular software exist. I also don't think we have the time or resources to thoroughly vet every submission to ensure the build process is entirely trustworthy. |
About that - some of the (completed) PRs seem to be waiting for more reviewers for over 30 days. (Disclosure: my PR happens to be one such PR (hence this comment), but I imagine other contributors in similar situation must be wondering as well.) Rather than ask in the PR, I tried to figure out what I don't mind waiting, but I do wonder how does a PR author "motivate" reviews of PRs that are "ready to go"? |
It means that anyone (and I mean anyone with a Github account) interested in seeing the PR move forward can use the review tab, check if everything is in order, and click There is no definition of an "official" reviewer, anyone can contribute to the review process.
Based on:
You can ping/send a reminder in the PR comments if you think it's been inactive for too long (30 days is too long). |
To add to the above, we get lots of PRs, if a project is well documented so that we can check it easily and accurately, this is also likely to get attention by reviewers, hence the anybody can review. If a project is convoluted and complicated to where someone with basic self hosting knowledge (i.e me) cant review it easily, then it is likely to be missed until someone with more knowledge, (i.e nodiscc) can review it with their expertise. This is why we it is important to make sure projects you add have documentation, new releases and are maintained so that we can review quickly and accurately, it is also important that when we make suggested changes, they are acted upon / or disputed against so that the PR doesn't sit dormant. |
Thank you both.
Yeah, that was another question I had. I obviously didn't want to attempt to review my own PR, but I wondered who may choose to do it. |
We welcome new reviewers, even if you don't feel qualified, there are simple things that you can check for that are often missed for example:
Even if you aren't sure, you can always make the suggested changes and they can be reverted if needed. Any questions you can always ask! The awesome selfhosted is a community list made for the community and maintained by the community! |
To avoid cluttering the Issues Tab with general discussions, questions, or other topics, I created a separate space to facilitate easier discussions on various subjects.
The text was updated successfully, but these errors were encountered: