"Redo" button not working

[krsaulitis]

Filament Version

v3.2.95

Plugin Version

v3.4.5

PHP Version

PHP 8.3.8

Problem description

The "redo" button or shortcut is not working in editor, nothing happens.

Screen.Recording.2024-07-22.at.13.39.25.mov

Expected behavior

The "redo" button reverts the changes after pressing undo.

Steps to reproduce

• Create a clean Laravel + FilamentPHP + TipTap Editor project
• Add TiptapEditor block to form schema
• Write some text into the editor, press undo, then redo

Reproduction repository

No response

Relevant log output

No response

[awcodes]

ueberdosis/tiptap#4821

[tlaverdure]

Hey there, it looks like there is some sort of recursion in this code which is causing the issue:

• User types in editor...
• onUpdate() sets this.state to editor.getJSON():
  

  filament-tiptap-editor/resources/js/plugin.js

  Lines 364 to 367 in 2fac924

  	onUpdate({editor}) {
  	_this.updatedAt = Date.now();
  	_this.state = editor.isEmpty ? null : editor.getJSON();
  	},

• Watch the state for changes:
  

  filament-tiptap-editor/resources/js/plugin.js

  Lines 325 to 332 in 2fac924

  	this.$watch('state', (newState, oldState) => {
  	if (typeof newState !== "undefined") {
  	if (!isEqual(oldState, Alpine.raw(newState))) {
  	this.updateEditorContent(newState)
  	}
  	}
  	});
  	},

• updateEditorContent() with current state:
  

  filament-tiptap-editor/resources/js/plugin.js

  Lines 404 to 410 in 2fac924

  	updateEditorContent(content) {
  	if (editor.isEditable) {
  	const {from, to} = editor.state.selection;
  	editor.commands.setContent(content, true);
  	editor.chain().focus().setTextSelection({from, to}).run();
  	}
  	},

I'm not really sure what the intent of updateEditorContent() is since it is called several times in various contexts, but if you comment editor.commands.setContent(content, true) the redo button works.

[awcodes]

hmm. Thanks for digging into the issue.

updateEditorContent is used to update the editor from outside of it, ie, through a livewire event or similar.

You may be right about the recursion though.

I'll have to give it some thought.

[awcodes]

Investigated this further. The issue is still in the Tiptap package itself. 'Redo' is not firing the 'onUpdate' event in Tiptap itself, meaning that the state of the allpine component is not getting updated.

While removing the setter in 'onUpdate' makes it work in the editor itself, it doesn't update the state in alpine, so saving the form wouldn't have the updated state of the redo.

[awcodes]

This is still a bug in the dependency, but I have a work around working in another version of the plugin I'm working on. Will try to get it back ported into this plugin if I can.

[yafkari]

Hey, came across this issue ueberdosis/tiptap#4821 then here, any update on this?

[awcodes]

Was working on this the other day. Still working on a fix.