Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Could not resolve dependency when using React 17 #22

Open
jpmc3630 opened this issue Nov 17, 2021 · 5 comments
Open

NPM Could not resolve dependency when using React 17 #22

jpmc3630 opened this issue Nov 17, 2021 · 5 comments

Comments

@jpmc3630
Copy link

Hey thanks for your work on the package.

I was wondering if you will be soon bumping the peer dependency to React version 17.

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from [email protected]

Thanks

@jpmc3630 jpmc3630 changed the title npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.8.0" from [email protected] NPM Could not resolve dependency when using React 17 Nov 17, 2021
@aviklai
Copy link
Owner

aviklai commented Nov 17, 2021

@jpmc3630 Hi,

I released version 2.0.3 which allows any react version equals or higher than 16.8.0.

@sammyjava
Copy link

sammyjava commented Jun 17, 2022

Still open as the target moves. Right now react-leaflet-kml has

peer react-leaflet@"^3.0.0" from [email protected]

But the current react-leaflet is react-leaflet@"^4.0.0" which supports react 18.2.0 (not 17) which is what all my code is on.

Any plans to bump react-leaflet-kml to react-leaflet@^4.0.0 in the near future? Or is this something you can point me toward doing? I think react-leaflet-kml is the ticket for me, I've spent a lot of time trying to get common JS KML stuff to work in React.

@aviklai
Copy link
Owner

aviklai commented Jun 17, 2022

@sammyjava Hi,

I have added support for leaflet 1.8.0, react leaflet 4 and react 18.
You can try version 2.0.4.
You can check the codesandbox example that uses leaflet 1.8.0 and react 18:
https://codesandbox.io/s/basic-usage-react-leaflet-v3-pzcvt

@sammyjava
Copy link

Thank you so much! This is great! I'll give you attribution on the site. You rock!

@sammyjava
Copy link

May have to thin them out a bit... :) (Gasoline stations with ethanol-free gas, from pure-gas.org)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants