Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting a TODO item also deletes the line following #40

Open
damiencourousse opened this issue Oct 31, 2018 · 3 comments
Open

deleting a TODO item also deletes the line following #40

damiencourousse opened this issue Oct 31, 2018 · 3 comments

Comments

@damiencourousse
Copy link
Contributor

Let's consider the test file below. Deleting issue 2 also deletes the comment line -- another comment 2.

-- file: test.hs

-- another comment 0
-- TODO (assig|#test) - issue 1
-- another comment 1
-- TODO (assig|#test) - issue 2
-- another comment 2
-- TODO (assig|#test) - issue 3
-- another comment 3

The issue does not appear with this test file, where issue 2 is not followed by a comment line.


-- another comment 0
-- TODO (assig|#test) - issue 1
-- another comment 1
-- TODO (assig|#test) - issue 2

-- TODO (assig|#test) - issue 3
-- another comment 3

@aviaviavi
Copy link
Owner

Ah so this was actually the intended behavior - I figured that for a TODO could have multiple lines as part of the body. So toodles interprets a TODO body as continuing all the way until the contiguous comment lines end, or another TODO is seen.

Would you prefer TODO's for a single line comment only be that line? I'm open to changing the behavior, especially if any other people reading agree.

@damiencourousse
Copy link
Contributor Author

damiencourousse commented Oct 31, 2018 via email

@Reisen
Copy link

Reisen commented Dec 3, 2018

If this does change, it would be wonderful if it could be an option. In Rust for example It's common to see multi-line comments using single line // for each line, and personally I'm relying on multi-line TODO notes as well. So I'd vote for current behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants