Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-ignored-test-files caches results too aggressively. #313

Open
jamestalmage opened this issue Oct 18, 2020 · 1 comment
Open

no-ignored-test-files caches results too aggressively. #313

jamestalmage opened this issue Oct 18, 2020 · 1 comment

Comments

@jamestalmage
Copy link
Contributor

It doesn't appear to pickup changes to package.json, only if I change the file under test.

It should abandon the cache if package.json has changed. (Or at least if the ava config portion has changed).

As an aside. Any linter rule that relies on caching should probably say so at the very top of the documentation.

NOTE: This rule relies on a cache to improve performance. Try `rm node_modules/.cache` if you think this might be affecting you.
@novemberborn
Copy link
Member

Since the matching logic is executed in AVA code, we should be able to return a cache key that maybe the rule implementation here can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants