Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreKtx(true) is not working #1283

Open
emartynov opened this issue Oct 10, 2024 · 2 comments
Open

ignoreKtx(true) is not working #1283

emartynov opened this issue Oct 10, 2024 · 2 comments
Milestone

Comments

@emartynov
Copy link

emartynov commented Oct 10, 2024

Plugin version
2.1.4

Gradle version
8.10.2

JDK version
23

(Optional) Kotlin and Kotlin Gradle Plugin (KGP) version
2.0.20

(Optional) Android Gradle Plugin (AGP) version
8.6.2

(Optional) reason output for bugs relating to incorrect advice
./gradlew sha:vide:reason --id androidx.lifecycle:lifecycle-runtime:2.8.6

:shared:video-player
\--- io.coil-kt:coil-base:2.7.0
      \--- androidx.lifecycle:lifecycle-runtime:2.8.6

Source: developDebug, main
--------------------------
(no usages)

./gradlew sha:vide:reason --id libs.androidx.lifecycle.runtime

Shortest path from :shared:video-player to androidx.lifecycle:lifecycle-runtime-ktx:2.8.6 (libs.androidx.lifecycle.runtime) for nowsecureReleaseUnitTestRuntimeClasspath:
:shared:video-player
\--- androidx.lifecycle:lifecycle-runtime-ktx:2.8.6

Source: developDebug, main
--------------------------
(no usages)

Describe the bug
The ktx dependency is proposed to be removed and the normal dependency is proposed to be added even we have

dependencyAnalysis {
    structure {
        ignoreKtx(true) // default is false
    }
}

In the root folder.

Expected behavior
ignoreKtx is respected

Additional context
Plugin is applied in root folder and then applied in every module. The ignoreKts is applied in the root file.

@autonomousapps autonomousapps added bug Something isn't working toolchain:android labels Oct 11, 2024
@autonomousapps autonomousapps added this to the next milestone Oct 11, 2024
@autonomousapps
Copy link
Owner

Thanks for the issue. Do you have a reproducer?

@emartynov
Copy link
Author

Sorry for the delay, let me try in small project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants