Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive with new style gradle test suite definition #1269

Open
gregallen opened this issue Sep 24, 2024 · 3 comments
Open

False positive with new style gradle test suite definition #1269

gregallen opened this issue Sep 24, 2024 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists more information needed toolchain:java

Comments

@gregallen
Copy link

Build scan link

Plugin version
2.0.2

Gradle version
8.10.1

JDK version
17

(Optional) Kotlin and Kotlin Gradle Plugin (KGP) version
NA

(Optional) Android Gradle Plugin (AGP) version
NA

(Optional) reason output for bugs relating to incorrect advice
warns junit -jupiter not needed at by testImplementation, but that dep is not explicitly present, nor is it shown by depedency-tree output.

Advice for root project
Unused dependencies which should be removed:
   testImplementation 'org junit jupiter: junit-jupiter:5.11.0'

Describe the bug
Gradle now offers "suite" concept for configuring junit with

testing {
  suites {
     configureEach {
      useJunitJupiter(junitVersion)

**To Reproduce**
Steps to reproduce the behavior:
1. ... run buildHealth

**Expected behavior**
health passes

**Additional context**
<!-- Add any other context about the problem here. -->
@autonomousapps autonomousapps added bug Something isn't working toolchain:java labels Oct 11, 2024
@autonomousapps autonomousapps added this to the next milestone Oct 11, 2024
@autonomousapps
Copy link
Owner

The plugin doesn't currently have any support for the jvm test suites stuff.

@autonomousapps autonomousapps modified the milestones: next, after next Oct 11, 2024
@autonomousapps autonomousapps added enhancement New feature or request duplicate This issue or pull request already exists and removed bug Something isn't working labels Oct 11, 2024
@autonomousapps
Copy link
Owner

Duplicates #1273

@autonomousapps autonomousapps added bug Something isn't working and removed enhancement New feature or request labels Oct 15, 2024
@autonomousapps
Copy link
Owner

Do you have a minimal reproducer?

@autonomousapps autonomousapps modified the milestones: after next, next Oct 15, 2024
@autonomousapps autonomousapps removed this from the next milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists more information needed toolchain:java
Projects
None yet
Development

No branches or pull requests

2 participants