Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Age feature in pbc2 #130

Open
ayushpatnaikgit opened this issue Oct 17, 2023 · 1 comment
Open

Age feature in pbc2 #130

ayushpatnaikgit opened this issue Oct 17, 2023 · 1 comment

Comments

@ayushpatnaikgit
Copy link

ayushpatnaikgit commented Oct 17, 2023

Hi,
In datasets.py, are you making age a dynamic covariate, instead of just using the initial value?

In that case,

age = data['age'] + data['years']

should change to

age = data['age'] + data['year']

years is the time of the event. year is the time indicator.

Here are some results:

Current:

In: x, t, e = datasets.load_dataset('PBC', sequential = True)
In: x[0][0][-1]
Out: 59.86200854232829

In: x[0][1][-1]
Out: 59.86200854232829

After the proposed change:

In: x, t, e = datasets.load_dataset('PBC', sequential = True)
In: x[0][0][-1]
Out: 58.7668382433468

In: x[0][1][-1]
Out: 59.29251998685791

I have tested this on the DeepSurvivalMachine package, but I believe this package uses the same module for loading datasets. I can redo these tests, and do a pull request if needed.

@matteo4diani
Copy link
Contributor

Hi Ayush 👋🏼 thanks for contributing to auton-survival 🙂
If you'd like to open a PR, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants