Skip to content

Commit 89c3b71

Browse files
committed
feat: apply manifest - remove redundant logs
1 parent 1aa3d4b commit 89c3b71

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/api/grpc/transport.grpc.api.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export const errorInterceptor: Interceptor = (next) => async (req) => {
4848
const userId = WorkspaceConfig.getFromWorkspace<string>("userId", "");
4949
const requestPath = req.url;
5050

51-
// Log only - let callers handle UI messages to avoid duplicates
5251
if (error.code === Code.Unauthenticated) {
5352
LoggerService.error(
5453
namespaces.authentication,

src/vscommands/applyManifest.vscommands.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,12 @@ export const applyManifest = async () => {
3636
});
3737

3838
if (createError) {
39-
// Handle specific error types with custom messages
4039
if (createError instanceof ConnectError) {
4140
const errorType = getFirstMetadataValue(createError, "x-error-type");
4241

43-
// Don't show error for AlreadyExists - it's handled silently
4442
if (createError.code === Code.AlreadyExists) {
4543
// Project already exists, continue to apply manifest
4644
} else if (errorType === "quota_limit_exceeded") {
47-
// Show quota exceeded error with details
4845
const quotaLimit = getFirstMetadataValue(createError, "x-quota-limit");
4946
const quotaLimitUsed = getFirstMetadataValue(createError, "x-quota-used");
5047
const quotaLimitResource = getFirstMetadataValue(createError, "x-quota-resource");
@@ -60,26 +57,21 @@ export const applyManifest = async () => {
6057
);
6158
return;
6259
} else if (errorType === "rate_limit_exceeded") {
63-
// Show rate limit error
6460
commands.executeCommand(vsCommands.showErrorMessage, translate().t("errors.rateLimitExceeded"));
6561
return;
6662
} else if (createError.code === Code.ResourceExhausted) {
67-
// Generic resource exhausted error
6863
commands.executeCommand(
6964
vsCommands.showErrorMessage,
7065
translate().t("errors.resourceExhausted", { email: SUPPORT_EMAIL })
7166
);
7267
return;
7368
} else if (createError.code === Code.Unauthenticated) {
74-
// Show auth error
7569
commands.executeCommand(vsCommands.showErrorMessage, translate().t("errors.unauthenticated"));
7670
return;
7771
} else if (createError.code === Code.PermissionDenied) {
78-
// Show permission error
7972
commands.executeCommand(vsCommands.showErrorMessage, translate().t("errors.permissionDenied"));
8073
return;
8174
} else {
82-
// Show generic error
8375
commands.executeCommand(vsCommands.showErrorMessage, namespaces.applyManifest, createError.message);
8476
return;
8577
}

0 commit comments

Comments
 (0)