You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ZeroshotSimulatorContext was written early on in the codebase and is hacky. It would be good to revisit and clean up the class, especially in terms of variable naming consistency with the rest of the package and more elegantly incorporating zpp/gt objects.
Most critically, the following code in init is very confusing, and we should make the most of property functions to minimize confusion and code complexity:
ZeroshotSimulatorContext was written early on in the codebase and is hacky. It would be good to revisit and clean up the class, especially in terms of variable naming consistency with the rest of the package and more elegantly incorporating zpp/gt objects.
Most critically, the following code in init is very confusing, and we should make the most of
property
functions to minimize confusion and code complexity:For example:
self.unique_dataset_folds
can simply beself.tasks
as a propertyself.unique_datasets
can simply beself.datasets
as a propertyself.dataset_to_tid_dict
can be simplified to a method callself.dataset_name_to_fold_dict
, which should be namedself.task_to_fold_dict
The text was updated successfully, but these errors were encountered: