Windows fixes and Windows CI (#710)

* fix(typescript-webpack): fix building on windows

* chore(appveyor): add Windows CI

fixes #501

* fix(webpack): more Windows-only fixes

* fix(webpack): use del-cli since del conflicts in Windows

* fix(typescript-webpack): fix Windows complaining about typings by using TS_NODE_FAST

* chore(CI): use YARN for all runners and enable all skeletons for testing

* chore(CI): add caches and node typings

* chore(CI): remove unnecessary build steps

* fix(typescript-webpack): invoke karma via ts-node

* fix(webpack): try adding reference to node types in the config file

* fix(esnext): incorrect babel preset in karma

* chore(CI): install missing modules in CI

* fix(esnext): incorrect babel preset in karma

* fix(jspm-typescript): typings postinstall

* chore(CI): add missing jspm installs to AppVeyor

Author: niieani

README.md

@@ -2,7 +2,8 @@
 
 [![ZenHub](https://raw.githubusercontent.com/ZenHubIO/support/master/zenhub-badge.png)](https://zenhub.io)
 [![Join the chat at https://gitter.im/aurelia/discuss](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/aurelia/discuss?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-[![CircleCI](https://circleci.com/gh/aurelia/skeleton-navigation.svg?style=shield)](https://circleci.com/gh/aurelia/skeleton-navigation)
+[![CI on Linux](https://circleci.com/gh/aurelia/skeleton-navigation.svg?style=shield)](https://circleci.com/gh/aurelia/skeleton-navigation)
+[![CI on Windows](https://ci.appveyor.com/api/projects/status/jeqgpvyyjh6wul9f?svg=true)](https://ci.appveyor.com/project/niieani/skeleton-navigation)
 
 ---
 

appveyor.yml

@@ -0,0 +1,46 @@
+# Test against this version of Node.js
+environment:
+  matrix:
+    - nodejs_version: "4"
+    - nodejs_version: "6"
+    - nodejs_version: "7"
+
+cache:
+  - skeleton-esnext/node_modules
+  - skeleton-esnext/jspm_packages
+  - skeleton-esnext-webpack/node_modules
+  - skeleton-typescript/node_modules
+  - skeleton-typescript/jspm_packages
+  - skeleton-typescript-webpack/node_modules
+  - "%LOCALAPPDATA%/Yarn"
+
+# Install scripts. (runs after repo cloning)
+install:
+  # Get the latest stable version of Node.js or io.js
+  - ps: Install-Product node $env:nodejs_version
+  - npm install -g jspm
+  # install modules
+  - cd skeleton-esnext-webpack && yarn
+  - cd skeleton-typescript-webpack && yarn
+  - cd skeleton-esnext && yarn
+  - cd skeleton-esnext && jspm install
+  - cd skeleton-typescript && yarn
+  - cd skeleton-typescript && jspm install
+
+# Post-install test scripts.
+test_script:
+  # Output useful info for debugging.
+  - node --version
+  - yarn --version
+  # run tests
+  - cd skeleton-typescript-webpack && yarn run test
+  - cd skeleton-typescript-webpack && yarn run e2e
+  - cd skeleton-typescript-webpack && yarn run build:prod
+  - cd skeleton-esnext-webpack && yarn run test
+  - cd skeleton-esnext-webpack && yarn run e2e
+  - cd skeleton-esnext-webpack && yarn run build:prod
+  - cd skeleton-esnext && yarn run test
+  - cd skeleton-typescript && yarn run test
+
+# Don't actually build.
+build: off

circle.yml

@@ -15,27 +15,26 @@ dependencies:
   override:
     - cd skeleton-esnext-webpack && yarn
     - cd skeleton-typescript-webpack && yarn
-    # - cd skeleton-esnext && yarn
-    # - cd skeleton-esnext && jspm install
-    # - cd skeleton-typescript && yarn
-    # - cd skeleton-typescript && jspm install
+    - cd skeleton-esnext && yarn
+    - cd skeleton-esnext && jspm install
+    - cd skeleton-typescript && yarn
+    - cd skeleton-typescript && jspm install
   cache_directories:
     - "skeleton-esnext/node_modules"
     - "skeleton-esnext/jspm_packages"
     - "skeleton-esnext-webpack/node_modules"
     - "skeleton-typescript/node_modules"
     - "skeleton-typescript/jspm_packages"
     - "skeleton-typescript-webpack/node_modules"
+    - "~/.yarn-cache"
 
 test:
   override:
-    - cd skeleton-esnext-webpack && npm test
-    - cd skeleton-esnext-webpack && npm run e2e
-    - cd skeleton-esnext-webpack && npm run build
-    - cd skeleton-esnext-webpack && npm run build:prod
-    - cd skeleton-typescript-webpack && npm test
-    - cd skeleton-typescript-webpack && npm run e2e
-    - cd skeleton-typescript-webpack && npm run build
-    - cd skeleton-typescript-webpack && npm run build:prod
-    # - cd skeleton-esnext && npm test
-    # - cd skeleton-typescript && npm test
+    - cd skeleton-typescript-webpack && yarn run test
+    - cd skeleton-typescript-webpack && yarn run e2e
+    - cd skeleton-typescript-webpack && yarn run build:prod
+    - cd skeleton-esnext-webpack && yarn run test
+    - cd skeleton-esnext-webpack && yarn run e2e
+    - cd skeleton-esnext-webpack && yarn run build:prod
+    - cd skeleton-esnext && yarn run test
+    - cd skeleton-typescript && yarn run test

skeleton-esnext-webpack/package.json

@@ -4,7 +4,7 @@
   "description": "A starter kit for building a standard navigation-style app with Aurelia and webpack.",
   "main": "dist/main.js",
   "scripts": {
-    "pretest": "del test/coverage",
+    "pretest": "del-cli \"test/coverage\"",
     "test": "cross-env BABEL_ENV=node NODE_ENV=test ./node_modules/karma/bin/karma start test/karma.conf.js",
     "test:debug": "npm test -- --single-run=false --debug",
     "webdriver:update": "cross-env ./node_modules/.bin/webdriver-manager update",
@@ -14,8 +14,8 @@
     "e2e:start-when-ready": "wait-on --timeout 120000 http-get://localhost:19876/index.html && npm run e2e:start",
     "e2e:start": "cross-env ./node_modules/.bin/protractor test/protractor.conf.js",
     "e2e:live": "npm run e2e:start -- --elementExplorer",
-    "clean": "npm cache clean && del node_modules test/coverage dist",
-    "clean:dist": "del dist",
+    "clean": "npm cache clean && del-cli node_modules \"test/coverage\" dist",
+    "clean:dist": "del-cli dist",
     "preclean:install": "npm run clean",
     "clean:install": "npm install",
     "preclean:start": "npm run clean",

skeleton-esnext/karma.conf.js

@@ -39,7 +39,7 @@ module.exports = function(config) {
     'babelPreprocessor': {
       options: {
         sourceMap: 'inline',
-        presets: [ 'es2015-loose', 'stage-1'],
+        presets: [ ['es2015', { loose: true }], 'stage-1'],
         plugins: [
           'syntax-flow',
           'transform-decorators-legacy',

skeleton-typescript-webpack/package.json

@@ -4,8 +4,8 @@
   "description": "A starter kit for building a standard navigation-style app with Aurelia and webpack.",
   "main": "dist/main.js",
   "scripts": {
-    "pretest": "del test/coverage",
-    "test": "cross-env NODE_ENV=test ./node_modules/karma/bin/karma start test/karma.conf.js",
+    "pretest": "del-cli \"test/coverage\"",
+    "test": "cross-env NODE_ENV=test TS_NODE_PROJECT=tsconfig.tsnode.json TS_NODE_FAST=true ts-node ./node_modules/karma/bin/karma start test/karma.conf.js",
     "test:debug": "npm test -- --single-run=false --debug",
     "webdriver:update": "cross-env ./node_modules/.bin/webdriver-manager update",
     "webdriver:start": "cross-env ./node_modules/.bin/webdriver-manager start",
@@ -14,8 +14,8 @@
     "e2e:start-when-ready": "wait-on --timeout 120000 http-get://localhost:19876/index.html && npm run e2e:start",
     "e2e:start": "cross-env ./node_modules/.bin/protractor test/protractor.conf.js",
     "e2e:live": "npm run e2e:start -- --elementExplorer",
-    "clean": "npm cache clean && del node_modules test/coverage dist",
-    "clean:dist": "del dist",
+    "clean": "npm cache clean && del-cli node_modules \"test/coverage\" dist",
+    "clean:dist": "del-cli dist",
     "preclean:install": "npm run clean",
     "clean:install": "npm install",
     "preclean:start": "npm run clean",
@@ -35,8 +35,8 @@
     "server:dev": "cross-env NODE_ENV=development npm run webpack-dev-server -- --inline --progress --profile --watch",
     "server:dev:hmr": "npm run server:dev -- --hot",
     "server:prod": "http-server dist --cors",
-    "webpack": "cross-env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' ./node_modules/.bin/webpack",
-    "webpack-dev-server": "cross-env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' ./node_modules/.bin/webpack-dev-server"
+    "webpack": "cross-env TS_NODE_PROJECT=tsconfig.tsnode.json TS_NODE_FAST=true ./node_modules/.bin/webpack",
+    "webpack-dev-server": "cross-env TS_NODE_PROJECT=tsconfig.tsnode.json TS_NODE_FAST=true ./node_modules/.bin/webpack-dev-server"
   },
   "repository": {
     "type": "git",
@@ -109,6 +109,7 @@
     "@easy-webpack/core": "^1.4.5",
     "@types/bluebird": "^3.0.35",
     "@types/jasmine": "^2.5.37",
+    "@types/node": "^6.0.46",
     "@types/webpack": "^1.12.35",
     "@types/whatwg-fetch": "^0.0.32",
     "aurelia-protractor-plugin": "^1.0.0",

skeleton-typescript-webpack/test/karma.conf.js

@@ -4,7 +4,6 @@
  */
 "use strict";
 const path = require('path');
-require('ts-node').register({ compilerOptions: { module: 'commonjs' }, disableWarnings: true, fast: true });
 
 module.exports = function(config) {
   config.set({

skeleton-typescript-webpack/tsconfig.tsnode.json

@@ -0,0 +1,6 @@
+{
+  "extends": "./tsconfig",
+  "compilerOptions": {
+    "module": "commonjs"
+  }
+}

skeleton-typescript-webpack/webpack.config.ts

@@ -1,3 +1,4 @@
+/// <reference path="./node_modules/@types/node/index.d.ts" />
 /**
  * To learn more about how to use Easy Webpack
  * Take a look at the README here: https://github.com/easy-webpack/core

skeleton-typescript/package.json

@@ -21,7 +21,7 @@
     "url": "http://github.com/aurelia/skeleton-navigation-typescript"
   },
   "scripts": {
-    "prepublish": "./node_modules/.bin/typings install",
+    "prepublish": "typings install",
     "test": "gulp test",
     "e2e": "gulp serve e2e"
   },