-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fork of cookidump #22
Comments
Hi, that's great. I propose you to open a merge request, where you integrate the behavior you have implemented in the original script (perhaps, by supporting additional input parameters on the main script). Then, after verifying it, I can merge your code and add you to the supporters of the program. |
OK. Since my changes are very extensive, I think the best way to do this is for me to break down my changes into several phases/features - for example, one change I made was to support Cookidoo "Created recipes", where the HTML is different from regular recipes. That change, and possibly others, might be best split off into separate merge requests, which would then be easier for you to verify. This splitting into multiple merge requests will take some time, so don't expect anything too quickly! |
I’ve created the first PR - a small one to fix a deprecation warning. Once you’ve accepted that, I’ll start on more for the other changes. |
Thank you, I've just merged your PR. I've also updated the |
I've created a new fork of cookidump at ndjc/cookidump. This version includes a python script dumpcollections.py that lists the contents of collections, and optionally writes out a JSON representation of the recipes in the collections. The JSON representation is compatible with the recipe management program Paprika 3, and includes the recipe image. The script also allows filtering of the collections and/or recipes dumped to those matching given regular expressions.
I wrote this entirely for my own use, but I'm happy to work with anyone here to merge all or parts of this variant into auino/cookidump if there is any interest in doing so.
The text was updated successfully, but these errors were encountered: