Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ES8388 based audio kits (AI-Thinker A1S audio Kit v2.2, Espressif LyraT V4.3) #118

Open
omski opened this issue Sep 14, 2021 · 15 comments
Labels
enhancement New feature or request

Comments

@omski
Copy link

omski commented Sep 14, 2021

Is your feature request related to a problem? Please describe.
My request is hardly related to the poor ADC performance of the ESP. There is another request regarding a second I2S input.
But there is an ESP variant which seems to match perfectly with WLED SR as this project is all about making LED dance to some noise with the help of an ESP.
The ESP A1S is has some special audio capabilities like:
microphone input
line input
audio coded with several supported formats
There is an dev kit available: https://github.com/Ai-Thinker-Open/ESP32-A1S-AudioKit

Describe the solution you'd like
Support for the ESP32 A1S and its audio input capabilities.

@omski omski added the enhancement New feature or request label Sep 14, 2021
@omski
Copy link
Author

omski commented Sep 16, 2021

I've got an answer to my request on espressif/arduino-esp32 in regards to support for the ESP A1S. espressif/arduino-esp32#5674
"if the manufacturer or someone from the community wants to add it, they are free to do so. Otherwise you can use the "ESP32 Dev Board" instead, which is compatible with all other boards."

So as the dev kits for the ESP A1S are reasonable priced one could think of making a version of WLED SR where the added features of the chip are supported out of the box?
https://www.aliexpress.com/item/32957553086.html
This will make life much easier because the board has already microphones and a line in with an ADC. No more struggles getting good audio signals into the ESP to calculate LED effects on 😉
Maybe the added features could be made accessible through user mods.

@atuline
Copy link
Owner

atuline commented Sep 16, 2021

If the microphone is already there, I would suspect that the pin select feature in WLED SR would allow you to use those features.

@omski
Copy link
Author

omski commented Sep 16, 2021

There are two of them and I suspect that they are not connected via the analog pin of the ESP instead through MIC input of the unbuild AC101 audio codec chip itself.
image
https://html.alldatasheet.net/html-pdf/1134488/XPOWER/AC101/249/1/AC101.html
image

Furthermore there is line input going to the AC101 too.

When we can figure out how to access these inputs it would be nice to have an env for that device don't you think?

Some stuff I have found related to this:
I found this https://platformio.org/lib/show/6755/AC101
espressif/esp-adf#554

@scruffynerf
Copy link

Supporting the esp32 LyraT (aka the es8388 chip)
As well would be nice. It's i2C

Separate add-on board:
https://pcbartists.com/products/es8388-module/esp32-es8388-audio-codec-interfacing/

@omski
Copy link
Author

omski commented Sep 29, 2021

@scruffynerf
Maybe this issue here #117 suits better to your proposal. It is about support for external I2S/I2C boards for line input.

Nice little add-on board! I am about to use one of these for a test: https://de.aliexpress.com/item/4000983028754.html

@tony-fav
Copy link

tony-fav commented Nov 4, 2021

This mic should be easily supported. I located this project which seems to use it with config not much different than that currently https://github.com/RealCorebb/ESP32-A1s-Audio-Kit/blob/master/Microphone.ino However, it seems to require an I2C setup step which can be found here https://github.com/Yveaux/AC101/blob/master/src/AC101.cpp

I have just created a PR for the ES7243 which similarly requires an I2C configuration step: #132

@omski do you have the board in hand?

@omski
Copy link
Author

omski commented Nov 8, 2021

@omski do you have the board in hand?

@tony-fav Yes it just arrived. I will try your solution as soon as I have some time to switch to the related project back again. Have you any advice for me to assure that I am not messing up with your proposal?
Would be great to have support for this board because it is cheap compared to what it has available. The I2S/I2C ADC add-on boards alone are more expensive.

@microfx
Copy link

microfx commented Feb 17, 2022

did it work after all?

@ewoudwijma
Copy link
Collaborator

Loses due to inactivity

@netmindz
Copy link

I have this board, it's on my to-do list to have a go at using it

Agree 100% that it would be much easier for people to get started with than messing about with building their own Line-in setup or trying different mic setups

@microfx
Copy link

microfx commented Jul 20, 2022

Yes, please!

@softhack007
Copy link
Collaborator

softhack007 commented Jul 20, 2022

I think that there is still (a lot) hope for these boards with built-in I2S audio peripherals, like

The newest revisions of both boards have an ES8388 I2S Audio Codec Chip.

@softhack007 softhack007 reopened this Jul 20, 2022
@softhack007 softhack007 changed the title ESP A1S support support audio dev kits (AI-Thinker A1S audio kit, Espressif LyraT) Jul 20, 2022
@softhack007 softhack007 changed the title support audio dev kits (AI-Thinker A1S audio kit, Espressif LyraT) support audio dev kits with ES8388 chip (AI-Thinker A1S audio Kit v2.2, Espressif LyraT V4.3) Jul 20, 2022
@softhack007 softhack007 changed the title support audio dev kits with ES8388 chip (AI-Thinker A1S audio Kit v2.2, Espressif LyraT V4.3) support ES8388 based audio kits (AI-Thinker A1S audio Kit v2.2, Espressif LyraT V4.3) Jul 20, 2022
@softhack007 softhack007 added the backburner keeping this on the backburner; we might consider it in future label Nov 12, 2022
@netmindz
Copy link

I've made a start on the ES8388 support https://github.com/netmindz/WLED/tree/ES8388

@netmindz
Copy link

MoonModules#5

@softhack007 softhack007 removed the backburner keeping this on the backburner; we might consider it in future label Nov 28, 2022
@netmindz
Copy link

This is now supported in MoonModules, do you need it back-porting to SR @omski ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants