Skip to content

Commit 18cb499

Browse files
authored
Merge pull request #56 from jdslv/jds/php-8.4-compat
PHP 8.4 compatibility
2 parents 5668fc6 + 4213928 commit 18cb499

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

.github/workflows/linux.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
php-versions: [ '7.2', '7.3' ]
17-
coverage: [ none ]
16+
php-versions: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
17+
coverage: [ xdebug ]
1818
include:
19-
- php-versions: '7.4'
20-
coverage: xdebug
19+
- php-versions: '7.2'
20+
coverage: none
21+
- php-versions: '7.3'
22+
coverage: none
2123
# see https://github.com/marketplace/actions/setup-php-action#nightly-build-setup
22-
- php-versions: '8.0'
23-
experimental: true
24-
- php-versions: '8.1'
24+
- php-versions: '8.4'
2525
experimental: true
2626
fail-fast: false
2727

classes/extension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class extension implements atoum\extension
1111
protected $runner;
1212
protected $test;
1313

14-
public function __construct(atoum\configurator $configurator = null)
14+
public function __construct(?atoum\configurator $configurator = null)
1515
{
1616
if ($configurator) {
1717
$parser = $configurator->getScript()->getArgumentsParser();

classes/model/coverage/method.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class method extends model
1111
private $branches;
1212
private $paths;
1313

14-
public function __construct($method, array $branches = null, array $paths = null)
14+
public function __construct($method, ?array $branches = null, ?array $paths = null)
1515
{
1616
$this->method = $method;
1717
$this->branches = $branches;

classes/sonar/xunit.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class xunit extends atoum\reports\asynchronous
1212
protected $score = null;
1313
protected $assertions = [];
1414

15-
public function __construct(atoum\adapter $adapter = null)
15+
public function __construct(?atoum\adapter $adapter = null)
1616
{
1717
parent::__construct();
1818

0 commit comments

Comments
 (0)