fix: getChildren return directly without extra local declaration

atom-community · Dec 7, 2020 · 86c1ff7 · 86c1ff7
1 parent 40cfc66
commit 86c1ff7
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/tree.h b/src/tree.h
@@ -6,22 +6,16 @@
 
 /** Get the children of a jsTree (Napi::Object) */
 inline std::optional<Napi::Array> getChildren(const Napi::Object &&jsTree, const string &&childrenKey) {
-    Napi::Array childrenArray;
-
     // determine if it has children
-    auto hasChildren = false;
     if (jsTree.HasOwnProperty(childrenKey)) {
         const auto childrenRaw = jsTree.Get(move_const(childrenKey));
         if (childrenRaw.IsArray()) {
-            childrenArray = childrenRaw.As<Napi::Array>();
+            const auto childrenArray = childrenRaw.As<Napi::Array>();
             if (childrenArray.Length() != 0) {
-                hasChildren = true;
+                return childrenArray;
             }
         }
     }
-    if (hasChildren) {
-        return childrenArray;
-    }
     return {};
 }