From eec6010e6b58df0730f19be0f34eb38d8e25101e Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Mon, 17 May 2021 23:07:42 -0500 Subject: [PATCH 1/2] feat: add more typescript rules --- src/typescript.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/typescript.js b/src/typescript.js index 60ddb02..4240c06 100644 --- a/src/typescript.js +++ b/src/typescript.js @@ -10,6 +10,28 @@ const pluginTypeScriptRulesExtra = { "@typescript-eslint/member-delimiter-style": "off", "@typescript-eslint/no-inferrable-types": "off", "@typescript-eslint/no-non-null-assertion": "off", + "no-shadow": "off", + "@typescript-eslint/no-shadow": "error", + "@typescript-eslint/no-dynamic-delete": "error", + "@typescript-eslint/no-extraneous-class": "error", + "@typescript-eslint/no-floating-promises": "error", + "@typescript-eslint/no-parameter-properties": "error", + "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error", + "@typescript-eslint/no-unnecessary-condition": "error", + "@typescript-eslint/no-unnecessary-qualifier": "error", + // "@typescript-eslint/no-unnecessary-type-arguments": "error", + "@typescript-eslint/no-unnecessary-type-constraint": "error", + "@typescript-eslint/no-unsafe-argument": "error", + // "@typescript-eslint/prefer-function-type": "error", + "@typescript-eslint/prefer-includes": "error", + // "@typescript-eslint/prefer-literal-enum-member": "error", + "@typescript-eslint/prefer-nullish-coalescing": "error", + "@typescript-eslint/prefer-optional-chain": "error", + "@typescript-eslint/prefer-reduce-type-parameter": "error", + // "@typescript-eslint/prefer-string-starts-ends-with": "error", + "@typescript-eslint/require-array-sort-compare": "error", + "@typescript-eslint/strict-boolean-expressions": "error", + "@typescript-eslint/switch-exhaustiveness-check": "warn", } exports.tsConfig = { From d3e5af50c0d51f48f06b4ef2bdea89dc1a8ec303 Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Mon, 17 May 2021 23:33:06 -0500 Subject: [PATCH 2/2] chore: add project option --- src/typescript.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/typescript.js b/src/typescript.js index 4240c06..7a06cf6 100644 --- a/src/typescript.js +++ b/src/typescript.js @@ -38,6 +38,9 @@ exports.tsConfig = { // TypeScript files files: ["**/*.ts", "**/*.tsx"], parser: "@typescript-eslint/parser", + parserOptions: { + project: ["./**/tsconfig.json", "!./**/node_modules/**/tsconfig.json"], + }, plugins: ["@typescript-eslint", "node", "import", "only-warn"], extends: [ "eslint:recommended",