Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve existing error #59

Open
athityakumar opened this issue Feb 7, 2018 · 4 comments
Open

Resolve existing error #59

athityakumar opened this issue Feb 7, 2018 · 4 comments
Labels
bug good first issue

Comments

@athityakumar
Copy link
Owner

The existing state of the code results in an error with Breaking Bad scraper. Most probably due to change in HTML format of the source website.

@the-ethan-hunt, would you like to address this (and also review the open PRs) when you're free?
@the-ethan-hunt
Copy link
Collaborator

Sure, @athityakumar , I would look at them when I get free. 😄
P.S. I would suggest you not to assign me this issue. We may have a newbie trying to venture in open-source and finding this one to start with. Just a suggestion. 😄

@yshubham
Copy link

Hey everyone , good to be here , but i don't see what exactly is braking up in the bb file , it seems fine on the web , Could anyone help please

@athityakumar
Copy link
Owner Author

@yshubham - The currently deployed website works fine. But we're to update the website (html files) by running the auto/ruby/index.rb file. If you run that file, you'll notice that there are some errors thrown by the bb_scraper.

@athityakumar
Copy link
Owner Author

This is being fixed at #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@athityakumar @the-ethan-hunt @yshubham