You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently I find the tests to be both to be brittle and not as clear as they could be. This is probably from a lack of an "ah ha!" moment.
I've made attempts to refactor with recent releases, but further work is needed to document exactly what is happening and why.
For example, one thing I spent an embarrassing amount of time on this AM was "remembering" the relationship between resError and error in the table test entries:
skipURLValbool// whether webhook URL validation is applied (e.g., GH-68)
}{
If I recall correctly, you're specifying what client error is expected (e.g., connectivity issue) and what error is expected from invoking library functions/methods using provided table test data.
This table test entry is an example of where there is no client error, but there is an error returned from validating the target endpoint or request URL:
Currently I find the tests to be both to be brittle and not as clear as they could be. This is probably from a lack of an "ah ha!" moment.
I've made attempts to refactor with recent releases, but further work is needed to document exactly what is happening and why.
For example, one thing I spent an embarrassing amount of time on this AM was "remembering" the relationship between
resError
anderror
in the table test entries:go-teams-notify/send_test.go
Lines 31 to 39 in cea9269
If I recall correctly, you're specifying what client error is expected (e.g., connectivity issue) and what error is expected from invoking library functions/methods using provided table test data.
This table test entry is an example of where there is no client error, but there is an error returned from validating the target endpoint or request URL:
go-teams-notify/send_test.go
Lines 50 to 59 in cea9269
The text was updated successfully, but these errors were encountered: