You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't recall off the top of my head where I learned that <br> was a good replacement, but it served the use case. Now it sounds like the ConvertEOLToBreak() function can be deprecated and one put in its place to substitute \n\n instead.
Now it sounds like the ConvertEOLToBreak() function can be deprecated and one put in its place to substitute \n\n instead.
Or it can remain, and be adapted to handle replacing a literal single use of \n with \n\n instead of <br>. This would allow the API surface it remain as is.
Now that recent work has been done to move the formatting functions of this project (atc0005/send2teams) into the atc0005/go-teams-notify project, I think this GH issue will follow suit and move to that project for future work as well.
While researching whether Markdown tables are supported via webhook requests (spoiler: it does not appear so), I stumbled across this line:
This is particularly useful to know, as I ended up going this route to work around the discovered behavior:
https://github.com/atc0005/send2teams/blob/170ac3bc6932c575174dd9ab1ccf84b39a001776/teams/teams.go#L31-L49
https://github.com/atc0005/send2teams/blob/170ac3bc6932c575174dd9ab1ccf84b39a001776/teams/teams.go#L255-L271
I don't recall off the top of my head where I learned that
<br>
was a good replacement, but it served the use case. Now it sounds like theConvertEOLToBreak()
function can be deprecated and one put in its place to substitute\n\n
instead.The text was updated successfully, but these errors were encountered: