Cannot add a adaptivecard.Card to action.ShowCard

[ArcticXWolf]

Hello,

I think I stumbled upon a bug in the current validation code of the Action.ShowCard. If I try to add this action, I get the following error:

error: specifying a Card is unsupported for Action type "Action.ShowCard": invalid field value

But the field Card is exclusively FOR the action type Action.ShowCard.

In line 1930 of adaptivecard.go the code checks if the action is of type Action.ShowCard. However afterwards in line 1932 it returns an error no matter what.

https://github.com/atc0005/go-teams-notify/blob/master/adaptivecard/adaptivecard.go#L1932

I think we need to catch the return value of line 1930 and then skip line 1932 if it is true. I think in the current implementation you cannot use Action.ShowCard at all.

If I just comment out line 1932, I can use the Action correctly.

[ArcticXWolf]

Oh and I am using the v2.11.0-alpha.1 version and go against the new MS Teams Workflow webhook. It works great so far. #262

[atc0005]

@ArcticXWolf: In line 1930 of adaptivecard.go the code checks if the action is of type Action.ShowCard. However afterwards in line 1932 it returns an error no matter what.

I believe you're right.

I went back over the earlier changes to the validation logic for Action.Validate() and I see what I intended, but missed. I don't believe this is needed any longer:

go-teams-notify/adaptivecard/adaptivecard.go

Lines 1932 to 1936 in 31c27ee

	return fmt.Errorf(
	"error: specifying a Card is unsupported for Action type %q: %w",
	a.Type,
	ErrInvalidFieldValue,
	)

I think we need to catch the return value of line 1930 and then skip line 1932 if it is true.

The validation helper collects any potential error as it is used and then returns it or nil here:

go-teams-notify/adaptivecard/adaptivecard.go

Lines 1939 to 1941 in 31c27ee

	// Return the last recorded validation error, or nil if no validation
	// errors occurred.
	return v.Err()

Incoming PR to address this.

[atc0005]

@ArcticXWolf Please test the change in v2.11.0-alpha.2:

• https://github.com/atc0005/go-teams-notify/releases/tag/v2.11.0-alpha.2

Based on your earlier testing I expect that you'll get the same results, but would appreciate the confirmation.

Thanks!

[ArcticXWolf]

Yes, it works :) Thank you!

[atc0005]

@ArcticXWolf Thanks for confirming!

Reopening this to serve as a tracking item for the next stable release.

Thanks also for reporting this.