-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] <Update Default Text for Buttons to Improve Clarity> #3500
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
I'd like to propose a fix for this by updating the default text to something more user-friendly, like "Add to Google Calendar" and "Download ICS File. Would it be okay for me to create a pull request addressing this? Let me know! |
@ChaitanyaKadu03 I have raised a PR that resolves this issue. |
I think the issue is suppose to be resolved in some other manner, you can have a look at #3488 |
In the above mentioned PR I linked the text of the buttons to the common.json file where every text for a button is stored but it was still not the required solution. |
@BalrajDhakad I think you misunderstood the issue and overcomplicating the solution. If there has to be made some changes then reviewers will respond to it. |
Closing as duplicate to #3465 |
Describe the bug.
The GoogleCalendarButton and ICSFileButton components on the Events Page use default text such as googleCalendarBtn, which appears to be a placeholder or untranslated key.
Expected behavior
The buttons should have clear, user-friendly default text that accurately describes their functionality, even if translation keys are used elsewhere. For example:
GoogleCalendarButton: Default text should be "Add to Google Calendar".
ICSFileButton: Default text should be "Download ICS File".
Screenshots
How to Reproduce
Update the default text values in the button components as follows:
Update GoogleCalendarButton -
text = 'Add to Google Calendar'
Update ICSFileButton similarly -
text = 'Download ICS File'
This is a minor UI/UX issue but can improve clarity by providing meaningful button labels by default.
🥦 Browser
Brave
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue ?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: