-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Newsletter page does not have correct button labels #3236
Comments
I can work on it! |
How do we access newsletter page? |
I am not sure either, I was just going through the codebase and found that we have |
@akshatnema do we need this url as we only have newsletter at the home page which is working fine |
@sambhavgupta0705 look at 'components/NewsletterSubscribe.tsx' |
Hey,@JeelRajodiya can you assign this to me. |
Issues are not assigned on the website repo (AFAIK). If the issue is valid, you can start working on it and a create PR. |
@JeelRajodiya I can still see this issue present on the website.Can i work on this ? |
I think PR #3308 is relevant to this issue and is still under review. You should avoid working on the issues which already have a PR open. |
Reopening this one |
@sambhavgupta0705 I think the issue was resolved in #3308. We can close this issue. |
Describe the bug.
The labels for the buttons and input fields simply have the i18n placeholders instead of the actual labels
Expected behavior
These are the expected labels
How to Reproduce
🥦 Browser
Google Chrome
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue ?
No, someone else can work on it
The text was updated successfully, but these errors were encountered: