Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update banner for paris conference #3098

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

thulieblack
Copy link
Member

Update the banner for upcoming Paris Conf

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit af563f1
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/669fd5478a58ed0008646856
😎 Deploy Preview https://deploy-preview-3098--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jul 17, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3098--asyncapi-website.netlify.app/

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it looks like on mobile.

Screenshot_20240718_081354_Samsung Internet.jpg

@thulieblack
Copy link
Member Author

/ptal

@asyncapi-bot
Copy link
Contributor

@derberg @magicmatatjahu @akshatnema @anshgoyalevil Please take a look at this PR. Thanks! 👋

@sambhavgupta0705
Copy link
Member

/update

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 2fe6689 into asyncapi:master Jul 23, 2024
15 checks passed
@thulieblack thulieblack deleted the paris-banner branch July 23, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants