Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: front page card correct alignment #2964 #2984

Closed
wants to merge 1 commit into from

Conversation

Arnab2002Pal
Copy link

@Arnab2002Pal Arnab2002Pal commented May 21, 2024

Description
refactor - The front page card is now aligned to the center of its parent div.
image

Resolved #2964

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 24566b3
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/664ce4cc8c75930008d5019a
😎 Deploy Preview https://deploy-preview-2984--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 26
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2984--asyncapi-website.netlify.app/

@Arnab2002Pal Arnab2002Pal changed the title front page card correct alignment #2964 Refactor - front page card correct alignment #2964 May 21, 2024
@Arnab2002Pal Arnab2002Pal changed the title Refactor - front page card correct alignment #2964 refactor: front page card correct alignment #2964 May 21, 2024
Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks for your contribution @antoniogarrote

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arnab2002Pal Kindly update the PR according to latest codebase.

@sambhavgupta0705
Copy link
Member

@Arnab2002Pal whats the status here

@Arnab2002Pal
Copy link
Author

@akshatnema , I am not sure if I understood you. I have already created the PR and what is the next step?
@sambhavgupta0705 , for status: I am not sure

@sambhavgupta0705
Copy link
Member

@Arnab2002Pal Akshat is saying to update your PR as we have migrated the codebase to typescipt so you have some merge conflicts
one fix is that your need to update your branch and then do git pull and git push
other fix is to close this one and then open a new PR from udpated codebase

@sambhavgupta0705
Copy link
Member

I think you must close this one and open a new PR with your changes

@sambhavgupta0705
Copy link
Member

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front page card is wrongly aligned
5 participants