Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken JSON schema links #2750

Closed
2 tasks done
gokerakc opened this issue Mar 8, 2024 · 3 comments
Closed
2 tasks done

Broken JSON schema links #2750

gokerakc opened this issue Mar 8, 2024 · 3 comments
Labels

Comments

@gokerakc
Copy link

gokerakc commented Mar 8, 2024

Describe the bug.

There are broken links in the sns and sqs binding schemas.

You can see some of the broken links below:

It seems like there is a problem with the /bindings path.

This bug affects spec-json-schemas repo (I've also created a similar issue there: asyncapi/spec-json-schemas#493).

Expected behavior

Links should return schemas.

Screenshots

Screenshot 2024-03-08 at 11 42 23

How to Reproduce

  1. Click the link
  2. Get a 404 response

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

@gokerakc gokerakc added the bug label Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Vishal2002
Copy link

Vishal2002 commented Mar 9, 2024

@gokerakc Getting 404 Error means it is not getting the operation.json file and I think we have to make that operation.json file to handle the routes.
Screenshot 2024-03-09 123132

@gokerakc
Copy link
Author

Hey @Vishal2002!

I guess external ref links are not needed at all because we already have the definition of the properties within the same file.

For example, the definition of the deliveryPolicy exists here but somehow ref items (here) use a broken link instead of pointing to that definition.

I'll update the JSON schema to fix the issue and close this one since the problem is not related to the website repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants