Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment of Code Editor Highlight Box #861

Open
princerajpoot20 opened this issue Nov 25, 2023 · 11 comments
Open

Misalignment of Code Editor Highlight Box #861

princerajpoot20 opened this issue Nov 25, 2023 · 11 comments
Assignees
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers stale

Comments

@princerajpoot20
Copy link
Member

Problem

Screenshot 2023-11-25 at 12 57 09 PM

The highlight box for the code editor mode in the EditorSwitch component is not centered and spills out of the boundary.

Viewing the Issue

See it here: Link

Expectation

It should be perfectly aligned.

@princerajpoot20
Copy link
Member Author

/gfi ts

@asyncapi-bot asyncapi-bot added area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Nov 28, 2023
@KhudaDad414
Copy link
Member

KhudaDad414 commented Nov 30, 2023

@princerajpoot20 In which environment is it not centred? I tried it on Chrome, Firefox and Sarafi. it is centred for me. 🤔

@princerajpoot20
Copy link
Member Author

@KhudaDad414 In Chrome on my system, it is not centered. In Safari, it is centered correctly, but the inner symbol are not visible. In Brave, it is displayed perfectly.

Chrome:
Screenshot 2023-11-30 at 9 55 04 PM
Safari:
Screenshot 2023-11-30 at 10 03 34 PM
Brave:
Screenshot 2023-11-30 at 10 04 17 PM

@adityagarg06
Copy link

For chrome, it is perfectly aligned:
image

I think the issue has been resolved.

@nikhil-3112
Copy link

Screenshot (179)

On Chrome and Opera browsers it is perfectly aligned. There is no issue with the alignment of the highlight box.
Issue Resolved.

@Amzani
Copy link
Collaborator

Amzani commented Feb 26, 2024

@princerajpoot20 you still see this issue ?

@princerajpoot20
Copy link
Member Author

@Amzani Yes, the issue is still there.
Link used in the browser: https://deploy-preview-978--asyncapi-studio-design-system.netlify.app/?path=/story/components-editorswitch--c

Screen.Recording.2024-02-27.at.7.16.03.PM.mov

@KhudaDad414
Copy link
Member

@princerajpoot20 since I can't reproduce it on my environment (tried with 3 browsers and it's centred.) can you open a PR with a fix?

@princerajpoot20
Copy link
Member Author

@KhudaDad414 Sure.

@lmgyuan
Copy link

lmgyuan commented Mar 20, 2024

@princerajpoot20 could it be that your chrome version is not updated? (Just a thought) browsers make all kinds of mistakes.

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers stale
Projects
Status: In progress
Development

No branches or pull requests

7 participants