Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates section button does not trigger events for closing or opening previous tabs #198

Closed
smoya opened this issue Dec 2, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@smoya
Copy link
Member

smoya commented Dec 2, 2021

Describe the bug

Unlike the events visualizer button, clicking on the new templates button opens a new view that covers the whole studio (except the nav bar). When clicking then on any other button like the code one CleanShot 2021-12-02 at 12 31 41, doesn't quit the examples view.

The only way to close it is to click again on the same examples button, which is not a 100% expected behavior because it is quite inconsistent with the rest.

How to Reproduce

See the following video:

recording.mp4

Expected behavior

Either examples view shows as a popup, or either just as a side view (as the events visualizer, code examples, etc), or we improve the navigation so on any click in any button will close the examples view.

@smoya smoya added the bug Something isn't working label Dec 2, 2021
@magicmatatjahu
Copy link
Member

Either examples view shows as a popup, or either just as a side view (as the events visualizer, code examples, etc), or we improve the navigation so on any click in any button will close the examples view.

The question is which would be better? From a UX standpoint, I think modal, @mcturco @boyney123 any thoughts? 🤔

@mcturco
Copy link
Member

mcturco commented Dec 3, 2021

@magicmatatjahu Agreed! I think a modal for the new templates will work just fine. So then the modal should close if you click a different nav item on the left side, as @smoya pointed out, good catch!

@magicmatatjahu
Copy link
Member

Nope, no close by clicking on the nav item. It will be similar to normal modal like:

image

But content will be templates :) And then you cannot click on the nav - you can try.

@mcturco
Copy link
Member

mcturco commented Dec 3, 2021

@magicmatatjahu Oh! Gotcha. Yes that works too!

@boyney123
Copy link
Contributor

Yeah modal sounds good to me! Nice catch @smoya

@boyney123
Copy link
Contributor

I can try and pick this up 👍

@boyney123
Copy link
Contributor

Think it's fixed in #201

@magicmatatjahu
Copy link
Member

Fixed in the #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants