-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates section button does not trigger events for closing or opening previous tabs #198
Comments
The question is which would be better? From a UX standpoint, I think modal, @mcturco @boyney123 any thoughts? 🤔 |
@magicmatatjahu Agreed! I think a modal for the new templates will work just fine. So then the modal should close if you click a different nav item on the left side, as @smoya pointed out, good catch! |
@magicmatatjahu Oh! Gotcha. Yes that works too! |
Yeah modal sounds good to me! Nice catch @smoya |
I can try and pick this up 👍 |
Think it's fixed in #201 |
Fixed in the #201 |
Describe the bug
Unlike the events visualizer button, clicking on the new templates button opens a new view that covers the whole studio (except the nav bar). When clicking then on any other button like the code one , doesn't quit the examples view.
The only way to close it is to click again on the same examples button, which is not a 100% expected behavior because it is quite inconsistent with the rest.
How to Reproduce
See the following video:
recording.mp4
Expected behavior
Either examples view shows as a popup, or either just as a side view (as the events visualizer, code examples, etc), or we improve the navigation so on any click in any button will close the examples view.
The text was updated successfully, but these errors were encountered: