Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: connection not initiated in MQTT due to broken firstConnect check #443

Merged
merged 2 commits into from
May 30, 2023
Merged

fix: connection not initiated in MQTT due to broken firstConnect check #443

merged 2 commits into from
May 30, 2023

Conversation

kaushik-rishi
Copy link
Contributor

Description

  • connection not initiated in MQTT due to broken firstConnect check
  • lot's on info in the linked issue

Related issue(s)

github-actions[bot]
github-actions bot reviewed May 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented May 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

KhudaDad414
KhudaDad414 approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for reporting and fixing it. 🙇

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5105770781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.53%
Totals Coverage Status
Change from base Build 5070706381: 0.0%
Covered Lines: 324
Relevant Lines: 454
💛 - Coveralls

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 02458fe into asyncapi:master May 30, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KhudaDad414
Copy link
Member

@all-contributors please add @kaushik-rishi for code.

@allcontributors allcontributors bot mentioned this pull request May 30, 2023
Closed
@allcontributors
Copy link
Contributor

@KhudaDad414

I've put up a pull request to add @kaushik-rishi! 🎉

@coveralls
Copy link

coveralls commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 5105770781

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.53%
Totals Coverage Status
Change from base Build 5070706381: 0.0%
Covered Lines: 324
Relevant Lines: 454
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@KhudaDad414 KhudaDad414 KhudaDad414 approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in MQTT Adapter post refactoring
4 participants
@kaushik-rishi @coveralls @KhudaDad414 @asyncapi-bot