but this path is not defined in your AsyncAPI file - Caused by trailing slash

[NaCl5alt]

Overview

Currently, attempts to access the Websocket API, including trailing slashes, result in an error but this path is not defined in your AsyncAPI file.
I believe that resolving this will make the library easier to use.

Solution

Make the following changes to _extractPathname.
If it looks good, assign me!

private _extractPathname(req: IncomingMessage) {
  const serverUrl = new URL(this.serverUrlExpanded)
  const { pathname } = new URL(req.url, serverUrl)

  if (!pathname) return '/'

  if (pathname.endsWith('/')) {
    return pathname.substring(0, pathname.length - 1)
  }

  return pathname
}

glee/src/adapters/ws/server.ts

Lines 183 to 187 in be4a2a6

	private _extractPathname(req: IncomingMessage) {
	const serverUrl = new URL(this.serverUrlExpanded)
	const { pathname } = new URL(req.url, serverUrl)
	return pathname || '/'
	}

Append

I was careless.
That you can also set an address in asyncapi.yaml that includes a trailing slash.
Perhaps we need to remove the trailing slash in the channels method of @asyncapi/parser for unification, and also in the tilde method of utils.ts if we want to make it more correct.
https://github.com/asyncapi/parser-js/blob/9742b8145020f43db598fe394702fbab5a9c868e/src/models/v3/asyncapi.ts#L61-L67

https://github.com/asyncapi/parser-js/blob/9742b8145020f43db598fe394702fbab5a9c868e/src/utils.ts#L113-L121

If the impact is too large, I would suggest changing the _getChannel method as follows

private _getChannel(req: IncomingMessage) {
  const pathName = this._extractPathname(req)
  return this.parsedAsyncAPI.channels().all().filter(channel => {
    let address = channel.address()
    if(address.endsWith('/')) address = address.substring(0, address.length - 1)

    return address === pathName
  })[0]
}

glee/src/adapters/ws/server.ts

Lines 95 to 98 in be4a2a6

	private _getChannel(req: IncomingMessage) {
	const pathName = this._extractPathname(req)
	return this.parsedAsyncAPI.channels().all().filter(channel => channel.address() === pathName)[0]
	}

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[Souvikns]

@NaCl5alt sorry for the late reply, do you still wanna work on it

[NaCl5alt]

@Souvikns
np, plz assign me if necessary

[KhudaDad414]

@NaCl5alt we do not assign issues on GitHub. please feel free to open a PR.

[NaCl5alt]

@KhudaDad414
OK, I'd like to tackle this issue.

[asyncapi-bot]

🎉 This issue has been resolved in version 0.36.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀