Version 2.4.0 not supported

[victormartingarcia]

Describe the bug

The step to generate the HTML from the AsyncAPI document does not work with version 2.4.0

How to Reproduce

Github action step:

    #In case you do not want to use defaults, you for example want to use different template
    - name: Generating HTML from my AsyncAPI document
      uses: docker://asyncapi/github-action-for-generator:2.0.3
      with:
        template: '@asyncapi/[email protected]'  #In case of template from npm, because of @ it must be in quotes
        filepath: CORE.yaml
        output: generated-html

AsyncAPI yaml file:

asyncapi: '2.4.0'
info:
  title: My service
  version: 0.0.1
  description: Service description

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[derberg]

@victormartingarcia sorry, this project was affected by a small error in our automated release pipeline, and @asyncapi/generator dependency did not get an update to version 1.9.5.

I just got back from the holidays, so it will take me a few days to update. If you need it faster, please open a PR to just bump @asyncapi/generator to latest version

[victormartingarcia]

@derberg just opened the PR, hope that fixes the issue

[derberg]

@victormartingarcia I left you a comment over there, one more thing needs to be done

[asyncapi-bot]

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[victormartingarcia]

@derberg thanks for merging it :)

Any idea on when this 2.1.0 will be available on Docker Hub? https://hub.docker.com/r/asyncapi/github-action-for-generator/tags

Let me know if I can help you with anything

[derberg]

@victormartingarcia damn, another release issue -> https://github.com/asyncapi/github-action-for-generator/runs/7878933640?check_suite_focus=true

the Docker image that is used for this action uses node 16, but we noticed some dependencies fail -> asyncapi/generator#801

I will have to ask you for another contribution 🙏🏼

afaik, we only have issues with devDependencies so there are 2 possible solutions for Dockerfile:

• switch from node:16 to node:14
• run npm install with --omit=dev flag

Actually, omitting dev is best as it will make the image smaller. Just remember that if you will also go with downgrading to 14, the flag should be --only=prod

I personally do not mind what node version is used in docker, as long as it works 😄

[derberg]

@victormartingarcia fyi, I just pushed https://github.com/asyncapi/github-action-for-generator/pull/235/files through our automation, so with your PR we will already have a dedicated check if the image is building, so you do not have to check on local

[victormartingarcia]

@derberg added the --omit=dev to Dockerfile npm install in a new PR #236