Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve current automation around MAINTAINERS.yaml by automated updates to tsc_members and maintainers teams #1620

Open
derberg opened this issue Dec 16, 2024 · 8 comments
Assignees
Labels
bounty enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Dec 16, 2024

Every time a name is added or removed to MAINTAINERS.yaml, it should be:

  • added or removed from tsc_members GH team
    • also might be that existing name, just have a tsc member flag changed - and this has to be taken into account
  • added or removed from maintainers GH team

Automation should react not only on real time changes. Current automation of MAINTAINERS.yaml is also supporting a schedule, where from time to time refresh MAINTAINERS.yaml - GH teams automation should be included in that flow.

This is Medium issue, but of you take into account AMBASSADORS file, and also update of AMBASSADORS team, this could move into Advanced issue.

Unknown:

  • how the API will behave if somebody did not accept invite to be added to the team. So let's say, today we invited somebody, then 3 days later we run refresh automation, and the person still did not accept invite - what happens then? handle errors, and log proper info
  • we kind also have to take into account new Maintainer is not yet invited organization member - so we also have to invite them in the flow, or remove them if they are removed from maintainers file

Current automation docs that also need an update: https://github.com/asyncapi/community/tree/master/.github/scripts/maintainers

@derberg derberg added the enhancement New feature or request label Dec 16, 2024
@aeworxet
Copy link
Contributor

Bounty Issue's service comment

Text labels: bounty/2025-Q1, bounty/medium, bounty/coding
First assignment to regular contributors: 2024-12-20 00:00:00 UTC+12:00
End Of Life after: 2025-01-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

@aeworxet
Copy link
Contributor

I would like to work on this Bounty Issue.

@aeworxet aeworxet moved this to No Assignee in Bounty Program Dec 16, 2024
@kunstewi
Copy link

I am willing to work on this. But can i make a PR if the issue gets assigned to someone else ?

@aeworxet
Copy link
Contributor

@aeworxet (githubID: 16149591) is an AsyncAPI Maintainer specified in https://raw.githubusercontent.com/asyncapi/community/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list.

@derberg
Copy link
Member Author

derberg commented Dec 16, 2024

I assigned to @aeworxet who is maintainer for long time and know the subject very well

@aeworxet
Copy link
Contributor

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Medium 2024-12-16 2025-01-06 2025-02-16 2025-01-19 2025-02-02 2025-02-16
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@aeworxet aeworxet moved this from No Assignee to In Progress in Bounty Program Dec 16, 2024
@kunstewi
Copy link

Okey Dokey !! Happy Holidays.

@derberg
Copy link
Member Author

derberg commented Dec 23, 2024

@aeworxet there is some code in https://github.com/asyncapi/community/blob/master/.github/workflows/tsc_management.yml so maybe just this needs to be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

4 participants