Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Removal of --renderer flag from command asyncapi new template #1738

Closed
2 tasks done
Adi-204 opened this issue Mar 20, 2025 · 2 comments · Fixed by #1739
Closed
2 tasks done

[FEATURE] Removal of --renderer flag from command asyncapi new template #1738

Adi-204 opened this issue Mar 20, 2025 · 2 comments · Fixed by #1739
Labels
enhancement New feature or request

Comments

@Adi-204
Copy link
Contributor

Adi-204 commented Mar 20, 2025

Why do we need this improvement?

As per generator releases nunjucks is deprecated (which means that user can still use it but it is not recommended) but when I tried to create template with
-r = nunjucks React template was created rather than Nunjucks below is the screenshot.

Image

How will this change help?

Removal of --renderer flag from command asyncapi new template and user will only able to create React template only. Changes in command documentation.

Screenshots

No response

How could it be implemented/designed?

Explain above

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

@Adi-204 Adi-204 added the enhancement New feature or request label Mar 20, 2025
@github-project-automation github-project-automation bot moved this to To Triage in CLI - Kanban Mar 20, 2025
@Adi-204
Copy link
Contributor Author

Adi-204 commented Mar 20, 2025

Waiting for approval from maintainers.

@Shurtu-gal
Copy link
Collaborator

Fair enough. Please open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants