From 9eb6f7528a3d343eec877bac58fff6afe6723ad2 Mon Sep 17 00:00:00 2001 From: ItshMoh Date: Mon, 30 Sep 2024 21:06:17 +0530 Subject: [PATCH 1/4] removed the redundant undefined --- library/src/helpers/__tests__/schema.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/library/src/helpers/__tests__/schema.test.ts b/library/src/helpers/__tests__/schema.test.ts index aaa5b6f7..7baae634 100644 --- a/library/src/helpers/__tests__/schema.test.ts +++ b/library/src/helpers/__tests__/schema.test.ts @@ -909,7 +909,6 @@ describe('SchemaHelpers', () => { 1, FIRST_CASE, OTHER_CASES, - undefined, ), ).toMatchSnapshot(); }); From bf03e2403728d98f8ba9fe4a66e14fa1d7fd5c39 Mon Sep 17 00:00:00 2001 From: ItshMoh Date: Wed, 2 Oct 2024 19:31:20 +0530 Subject: [PATCH 2/4] removed the target =_blank --- library/src/components/Href.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/library/src/components/Href.tsx b/library/src/components/Href.tsx index fd5c3aff..abb62ac7 100644 --- a/library/src/components/Href.tsx +++ b/library/src/components/Href.tsx @@ -17,7 +17,6 @@ export const Href: React.FunctionComponent = ({ href={href} title={title} className={className} - target="_blank" rel="nofollow noopener noreferrer" > {children} From c5f177f6ae8507c3085510187ca605cc1851876b Mon Sep 17 00:00:00 2001 From: ItshMoh Date: Tue, 8 Oct 2024 14:36:59 +0530 Subject: [PATCH 3/4] fixed linting issue --- library/src/helpers/__tests__/schema.test.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/library/src/helpers/__tests__/schema.test.ts b/library/src/helpers/__tests__/schema.test.ts index 7baae634..d6c7acd2 100644 --- a/library/src/helpers/__tests__/schema.test.ts +++ b/library/src/helpers/__tests__/schema.test.ts @@ -905,11 +905,7 @@ describe('SchemaHelpers', () => { ).toMatchSnapshot(); expect( - SchemaHelpers.applicatorSchemaName( - 1, - FIRST_CASE, - OTHER_CASES, - ), + SchemaHelpers.applicatorSchemaName(1, FIRST_CASE, OTHER_CASES), ).toMatchSnapshot(); }); From 1cdbae309bdcc33242044bb572d2a12f840f6b1f Mon Sep 17 00:00:00 2001 From: ItshMoh Date: Mon, 14 Oct 2024 21:10:38 +0530 Subject: [PATCH 4/4] fixed some issue --- library/src/components/Href.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/library/src/components/Href.tsx b/library/src/components/Href.tsx index abb62ac7..fd5c3aff 100644 --- a/library/src/components/Href.tsx +++ b/library/src/components/Href.tsx @@ -17,6 +17,7 @@ export const Href: React.FunctionComponent = ({ href={href} title={title} className={className} + target="_blank" rel="nofollow noopener noreferrer" > {children}