Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for post install scripts #69

Closed
BryceRussell opened this issue May 1, 2024 · 1 comment
Closed

API for post install scripts #69

BryceRussell opened this issue May 1, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@BryceRussell
Copy link
Member

There are some cases where ATP may want to add a post install script to themes. This is useful for running code that only needs to be run once, instead of running it every time a project starts. For example, seeding a content collection with content. ATP could have an API for injecting post install scripts into a theme package.

Related: Modifying a user's package.json

Things to consider:

  • Currently, themes do not have to be authored as a package. Requiring a post install script for themes requires themes be authored as packages. That means any ATP themes not published to NPM would have to be authored inside a workspace.
@BryceRussell BryceRussell added enhancement New feature or request question Further information is requested labels May 1, 2024
@BryceRussell
Copy link
Member Author

We should avoid using a post install pattern unless it is absolutely necessary, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant