Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Possibility to use std::reduce or std::accumulate instead of raw loop #380

Open
krishnakumarg1984 opened this issue Jun 22, 2023 · 0 comments

Comments

@krishnakumarg1984
Copy link
Collaborator

In sdmm.h, it looks like a standard accumulation operation is implemented with a raw loop.

    for (auto const &transform : this->transforms())
      out += transform.adjoint() * static_cast<t_Vector>(transform * input);

Might be possible to use std::accumulate or std::reduce (parallelised in C++17). Thoughts?

@krishnakumarg1984 krishnakumarg1984 changed the title Code quality: Possibility to use std::reduce or std::accumulate instead of raw loop Performance: Possibility to use std::reduce or std::accumulate instead of raw loop Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant