-
Notifications
You must be signed in to change notification settings - Fork 67
Description
First off thanks for all the work putting this together, clearly no small effort. As a developer that is fairly familiar with ffmpeg as a CLI tool as well as Go, this tool looks really interesting for those cases where the CLI just isn't enough.
One thing that feels like it is particularly missing for me is clear documentation on memory management. When to call free/unref/etc is not super clear if you aren't familiar with the ffmpeg API.
Also, generally including more godocs would be nice. The examples provide a great starting point but for anything more complex it's a bit of guess work. For example I would like to write muxed data into memory buffers so I can handle transport in the rest of my go code. I didn't see an example so I took a guess and made an output format context with an empty string target and fed it an in context similar to the custom io example for reading. Having some documentation on AllocOutputFormatContext would have made this behavior clearer.