Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding PEP-695 type alias support #246

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

keller00
Copy link
Contributor

@keller00 keller00 commented Aug 7, 2023

I tried my best to add support for the new generic type-aliases from PEP-695.

fixes #231

@keller00 keller00 marked this pull request as draft August 7, 2023 02:32
@keller00 keller00 marked this pull request as ready for review August 8, 2023 01:54
@keller00
Copy link
Contributor Author

@asottile when you have the chance could you take a look, please?

add_trailing_comma/_plugins/pep695.py Outdated Show resolved Hide resolved
add_trailing_comma/_plugins/pep695.py Outdated Show resolved Hide resolved
tests/features/pep695_test.py Show resolved Hide resolved
add_trailing_comma/_plugins/pep695.py Outdated Show resolved Hide resolved
tests/features/pep695_test.py Outdated Show resolved Hide resolved
tests/features/pep695_test.py Show resolved Hide resolved
@asottile asottile force-pushed the keller00/pep-695-type-aliases branch from 5c81007 to 25be853 Compare August 30, 2023 17:20
Copy link
Owner

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile force-pushed the keller00/pep-695-type-aliases branch from 25be853 to a7f4d29 Compare August 30, 2023 17:23
@asottile asottile merged commit 6eccc5a into asottile:main Aug 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add trailing commas in PEP 695 type aliases
2 participants