Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate OIDC2 behavior #1061

Open
jrozner opened this issue Mar 3, 2024 · 0 comments
Open

Re-evaluate OIDC2 behavior #1061

jrozner opened this issue Mar 3, 2024 · 0 comments
Labels
triage Issue needs triage

Comments

@jrozner
Copy link
Member

jrozner commented Mar 3, 2024

I believe that right now the OIDC2 claims are only checked at authN time. Once a user has been logged in, the sessions lasts until the session is invalidated and all OIDC2 workflows are shortcut. This means that the sessions length of the claim is ignored and we don't leverage the refresh tokens to refresh the auth token so a user who is no longer authenticated to the IdP, has exceeded the timeout of the session as dictated by the IdP, or has had access within the IdP removed will still remain logged in. This is probably not desired or expected behavior and we should probably change it.

I'm not clear store in the session today and how much of it is necessary. Maybe in the case of federated auth we can allow the IdP to provide that information in the auth token's scope or maybe we continue to maintain an application specific session but when the user has authenticated via federated auth, we force it to recheck the validity of the session where applicable.

This might make sense to do along side #1027 as some aspects may change as part of that if we decide to make any changes.

@jrozner jrozner added the triage Issue needs triage label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

1 participant