You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ASDF standard 1.6.0 is nearing a stable point: #1744
It is likely that no more schema changes will be made to the 1.6.0 standard. After downstream packages update, 1.6.0 can be enabled as the new default and no longer be marked as "development":
If a file was written using asdf < 2.14 and standard 1.6.0 was enabled. The file will have been produced with a ndarray-1.0.0 tag which is no longer readable (a AsdfConversionWarning and tagged representation will instead be returned).
This issue highlights some dangers to allowing asdf to produce files with "developement" standard versions with no warnings to the user that the file they are producing may at some point in the future be unreadable.
This issue documents the incompatibility. #1771 addresses the currently failing compatibility tests (which only revealed the issue after the asdf-standard release as they only use the released version of asdf-standard).
For any asdf users who might find this issue please reach out if you have difficulty reading files that were previously written with 1.6.0.
In the future the following may help to avoid re-occurance of this issue:
raise a UserWarning if a file is written with a development version (this can be caught and filtered in tests)
consider disabling the development version for non-development installs
run compatibility tests with the development version of asdf-standard to evaluate asdf-standard PRs
The text was updated successfully, but these errors were encountered:
ASDF standard 1.6.0 is nearing a stable point:
#1744
It is likely that no more schema changes will be made to the 1.6.0 standard. After downstream packages update, 1.6.0 can be enabled as the new default and no longer be marked as "development":
asdf/asdf/versioning.py
Line 161 in aedf156
However, 1.6.0 contains a new ndarray schema version (and tag version):
https://github.com/asdf-format/asdf-standard/blob/main/resources/schemas/stsci.edu/asdf/core/ndarray-1.1.0.yaml
This creates an issue for asdf versions older than 2.14 as they have hard-coded support for only a single version (1.0.0):
asdf/asdf/tags/core/ndarray.py
Lines 213 to 216 in 8d535c6
If a file was written using asdf < 2.14 and standard 1.6.0 was enabled. The file will have been produced with a
ndarray-1.0.0
tag which is no longer readable (aAsdfConversionWarning
and tagged representation will instead be returned).This issue highlights some dangers to allowing asdf to produce files with "developement" standard versions with no warnings to the user that the file they are producing may at some point in the future be unreadable.
This issue documents the incompatibility. #1771 addresses the currently failing compatibility tests (which only revealed the issue after the
asdf-standard
release as they only use the released version ofasdf-standard
).For any asdf users who might find this issue please reach out if you have difficulty reading files that were previously written with 1.6.0.
In the future the following may help to avoid re-occurance of this issue:
UserWarning
if a file is written with a development version (this can be caught and filtered in tests)The text was updated successfully, but these errors were encountered: