Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find way to deprecate ndarray validators being applied to all tags #1693

Open
braingram opened this issue Nov 24, 2023 · 0 comments
Open

Find way to deprecate ndarray validators being applied to all tags #1693

braingram opened this issue Nov 24, 2023 · 0 comments
Milestone

Comments

@braingram
Copy link
Contributor

Description of the problem

As noted in the code:

class NdimValidator(Validator):
schema_property = "ndim"
# The validators in this module should really only be applied
# to ndarray-* tags, but that will have to be a 3.0 change.
tags = ["**"]

In asdf 3.x we can introduce some sort of deprecation for this behavior (perhaps warning when the validation fails on a non-ndarray tag) so that the validation can be restricted to ndarray tags in asdf 4.0 (this issue is milestoned for 4.0 as there is not yet a target 3.x version for this deprecation).

@braingram braingram added this to the 4.0.0 milestone Nov 24, 2023
@braingram braingram modified the milestones: 4.0.0, 4.x.x Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant