Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests assume being ran in certain timezone #2354

Open
alloy opened this issue Oct 15, 2019 · 0 comments
Open

Tests assume being ran in certain timezone #2354

alloy opened this issue Oct 15, 2019 · 0 comments
Labels

Comments

@alloy
Copy link
Contributor

alloy commented Oct 15, 2019

When I run the test suite (in my CEST timezone), the following tests fail:

Summary of all failing tests
 FAIL  src/client/apps/edit/components/admin/components/article/test/article_publish_date.test.tsx
  ● ArticlePublishDate › time › Can change the time

    expect(received).toMatch(expected)

    Expected value to match:
      "02:34"
    Received:
      "2017-05-19T00:34:00.000Z"

      119 | 
      120 |       expect(props.onChange.mock.calls[0][0]).toBe("published_at")
    > 121 |       expect(props.onChange.mock.calls[0][1]).toMatch("02:34")
          |                                               ^
      122 |     })
      123 |   })
      124 | 

      at Object.toMatch (src/client/apps/edit/components/admin/components/article/test/article_publish_date.test.tsx:121:47)

 FAIL  src/client/apps/edit/components/admin/components/article/test/index.test.tsx
  ● AdminArticle › Editing › Can change video release date

    expect(received).toMatch(expected)

    Expected value to match:
      "2017-02-07"
    Received:
      "2017-02-06T23:00:00.000Z"

      377 | 
      378 |       expect(props.onChangeArticleAction.mock.calls[0][0]).toEqual("media")
    > 379 |       expect(props.onChangeArticleAction.mock.calls[0][1].release_date).toMatch(
          |                                                                         ^
      380 |         "2017-02-07"
      381 |       )
      382 |     })

      at Object.toMatch (src/client/apps/edit/components/admin/components/article/test/index.test.tsx:379:73)

 FAIL  src/client/apps/settings/client/curations/gucci/test/section.test.tsx
  ● Section Admin › Updates release date and saves as iso

    expect(received).toMatch(expected)

    Expected value to match:
      "2017-11-15T"
    Received:
      "2017-11-14T23:00:00.000Z"

      127 | 
      128 |     expect(props.onChange.mock.calls[0][0]).toMatch("release_date")
    > 129 |     expect(props.onChange.mock.calls[0][1]).toMatch("2017-11-15T")
          |                                             ^
      130 |   })
      131 | 
      132 |   it("Updates video url on input", () => {

      at Object.toMatch (src/client/apps/settings/client/curations/gucci/test/section.test.tsx:129:45)


Test Suites: 3 failed, 113 passed, 116 total
Tests:       3 failed, 7 skipped, 1311 passed, 1321 total

These tests should not assume the timezone to be New York (probably?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant