Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending messages that repeatedly receive an invalid response #2

Open
arthurrump opened this issue Oct 1, 2022 · 0 comments
Open

Comments

@arthurrump
Copy link
Owner

If the response is of type UNKNOWN_DATA_ID, the boiler does not recognize this type of message and we can immediately stop sending it. If the response has type DATA_INVALID then the requested data is not available or invalid (in the case of a read request). If that happens consistently, say 10 times in a row with backoff, then we should assume that the message is not supported and stop sending it.

If DATA_INVALID is sent as response to a write request, we sent some invalid data. That should not happen and warrants opening an issue here, so that should be included in the log message. If it also happens repeatedly, disabling still seems reasonable.

FreeBear-nc added a commit to FreeBear-nc/esphome-opentherm that referenced this issue Nov 10, 2024
Fix freebear-nc/opentherm_library link
FreeBear-nc pushed a commit to FreeBear-nc/esphome-opentherm that referenced this issue Nov 16, 2024
Add get_[min|max]_value() functions and clamp the output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant