Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test file name regex #36

Open
ghost opened this issue Apr 19, 2017 · 2 comments
Open

Test file name regex #36

ghost opened this issue Apr 19, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 19, 2017

Hi! I just started using yasnippet and noticed that minitest-mode isn't identifying my test files (test_*.rb). At first it seemed odd since it does run my tests. Then I looked at the code and noticed it can also run minitest specs, awesome! I came up with a regex for minitest-test-file-name-re that covers test_*.rb, _spec.rb, [-_]test.rb so yasnippet is on by default regardless of test file naming style. Would it be ok to change it or is there a reason behind only covering [-_]test.rb files? Cheers!

@arthurnn
Copy link
Owner

arthurnn commented Apr 22, 2017

Would it be ok to change it or is there a reason behind only covering [-_]test.rb files?

should be ok. wanna send a PR?

@ghost
Copy link
Author

ghost commented Apr 26, 2017

I tried writing a test checking that a buffer enters minitest-mode only with file names matching the regex but couldn't figure out how to do it. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant