Small code improvements/cleanup (#582)

Increase E2E tests timeout
Don't cache node_modules on CI to avoid TS compilation bugs

Author: artembatura

.cirrus.yml

@@ -2,9 +2,6 @@ container:
   image: nikolaik/python-nodejs:python3.5-nodejs14-alpine
 
 test_task:
-  node_modules_cache:
-    folder: node_modules
-    fingerprint_script: cat yarn.lock
-    populate_script: yarn install
+  install_script: yarn install
   build_script: yarn compile
   test_script: yarn test

examples/__tests__/react-typescript.test.ts

@@ -9,7 +9,7 @@ import { terminateDevServer } from '../../e2e-helpers/terminateDevServer';
 const workPath = path.resolve(path.join(__dirname, '..'), 'react-typescript');
 
 describe('example:react-typescript', () => {
-  beforeAll(() => jest.setTimeout(1000 * 45));
+  beforeAll(() => jest.setTimeout(1000 * 120));
 
   it('start', async () => {
     const devServerPort = await getPort();

examples/__tests__/react.test.ts

@@ -9,7 +9,7 @@ import { terminateDevServer } from '../../e2e-helpers/terminateDevServer';
 const workPath = path.resolve(path.join(__dirname, '..'), 'react');
 
 describe('example:react', () => {
-  beforeAll(() => jest.setTimeout(1000 * 45));
+  beforeAll(() => jest.setTimeout(1000 * 120));
 
   it('start', async () => {
     const devServerPort = await getPort();

packages/core/src/Task.ts

@@ -42,11 +42,3 @@ export class Task<TOptions extends {}, _TArgs extends string[]> {
     return this._handler(args, options);
   }
 }
-
-// replace with factory
-// const task = new Task('task-0')
-// .expectArguments(new StringRule().maxLength(1), new StringRule())
-// .expectOption('option-0', new StringRule())
-// .handle(([arg0], options) => {});
-
-// task.run(['abc', 'ac'], { 'option-0': '123' });

packages/core/src/WorkSpace.ts

@@ -13,24 +13,4 @@ export class WorkSpace {
   };
 
   public constructor(public readonly name: string) {}
-
-  // private readonly rootDepNode: DependencyNode = new DependencyNode('root');
-  // private readonly beforeApplyMap: Map<string, Function> = new Map();
-
-  // public beforeApply<
-  //   T extends PluginConstructor,
-  //   TPlugin = T extends PluginConstructor<infer R> ? R : never
-  // >(PluginClass: T, id: string, fnCallback: (plugin: TPlugin) => void): void {
-  //   const dependencyNode =
-  //     findRecursive(this.rootDepNode, PluginClass.name) ||
-  //     this.rootDepNode.addOrGetEdge(PluginClass.name);
-  //
-  //   const callbackId = `${PluginClass.name}/${id}`;
-  //
-  //   this.beforeApplyMap.set(callbackId, fnCallback);
-  //
-  //   dependencyNode.addOrGetEdge(callbackId);
-  //
-  //   return undefined;
-  // }
 }

packages/core/src/graph/findRecursive.ts

@@ -1,4 +1,2 @@
 export * from './DependencyNode';
 export * from './resolve';
-export * from './findRecursive';
-export * from './traverseRecursive';

packages/core/src/graph/index.ts

@@ -103,34 +103,32 @@ export class WebpackSpaPlugin<
                 }
               ])
             );
-
-            modifications.insertPlugin(
-              new FriendlyErrorsPlugin({
-                compilationSuccessInfo: {
-                  messages: [
-                    `Your application successfully built and available at ${paths.build
-                      .split(path.sep)
-                      .pop()} folder`
-                  ]
-                }
-              })
-            );
-          } else {
-            modifications.insertPlugin(
-              new FriendlyErrorsPlugin({
-                compilationSuccessInfo: {
-                  messages: [
-                    'Your application is available at http://localhost:8080'
-                  ],
-                  notes: [
-                    'The development build is not optimized',
-                    'To create a production build, run `build` script'
-                  ]
-                }
-              })
-            );
           }
 
+          modifications.insertPlugin(
+            isDev
+              ? new FriendlyErrorsPlugin({
+                  compilationSuccessInfo: {
+                    messages: [
+                      'Your application is available at http://localhost:8080'
+                    ],
+                    notes: [
+                      'The development build is not optimized',
+                      'To create a production build, run `build` script'
+                    ]
+                  }
+                })
+              : new FriendlyErrorsPlugin({
+                  compilationSuccessInfo: {
+                    messages: [
+                      `Your application successfully built and available at ${paths.build
+                        .split(path.sep)
+                        .pop()} folder`
+                    ]
+                  }
+                })
+          );
+
           modifications.insertPlugin(
             new HtmlWebpackPlugin({
               inject: true,