From 0ead2265a55677473a3429878728d6e108bce22b Mon Sep 17 00:00:00 2001
From: vmork <vallemork@gmail.com>
Date: Sun, 17 Nov 2024 21:41:24 +0100
Subject: [PATCH] fix sidebar desktop ui and remove close sidebar button on
 desktop

---
 src/app/student/map/_components/MainView.tsx |  2 +-
 src/app/student/map/_components/Sidebar.tsx  | 20 ++++++--------------
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/src/app/student/map/_components/MainView.tsx b/src/app/student/map/_components/MainView.tsx
index 502b41c..4bd6541 100644
--- a/src/app/student/map/_components/MainView.tsx
+++ b/src/app/student/map/_components/MainView.tsx
@@ -94,7 +94,7 @@ export default function MainView({
             filteredBooths={filteredBooths}
             setFilteredBooths={setFilteredBooths}
           />
-          <div className="h-[calc(100dvh-144px)] flex-grow">
+          <div className="h-[calc(100dvh-144px)] sm:h-full flex-grow">
             <MapComponent
               initialView={initialView}
               boothsById={currentLocationBoothsById}
diff --git a/src/app/student/map/_components/Sidebar.tsx b/src/app/student/map/_components/Sidebar.tsx
index ee9b25b..0d5ac58 100644
--- a/src/app/student/map/_components/Sidebar.tsx
+++ b/src/app/student/map/_components/Sidebar.tsx
@@ -33,8 +33,6 @@ import { ScrollArea, ScrollBar } from "@/components/ui/scroll-area"
 import { cn } from "@/lib/utils"
 import {
   ArrowLeft,
-  ChevronsLeft,
-  ChevronsRight,
   EraserIcon,
   FilterIcon,
   MapIcon,
@@ -135,7 +133,6 @@ export default function Sidebar({
               onClick={() => setActiveDrawerBoothId(null)}>
               <ArrowLeft size={30} className="stroke-stone-400" />
             </Button>
-
             <div className="flex justify-end py-2">
               <Button
                 className="flex gap-2"
@@ -342,22 +339,17 @@ function SidebarContainer({
     )
   }
 
+  // Sidebar is always open on desktop
   return (
-    <div className={cn("relative h-full", open ? "w-[500px]" : "w-0")}>
+    <div className={cn("relative h-full w-[500px] overflow-hidden")}>
+      <DrawerHeader>
+        <Dialog>{header}</Dialog>
+      </DrawerHeader>
+
       <ScrollArea className="h-full">
         {children}
         <ScrollBar></ScrollBar>
       </ScrollArea>
-
-      <div className="absolute right-[-38px] top-0 z-20">
-        <Button
-          variant="ghost"
-          className="rounded-s-none border-none p-1"
-          onClick={() => setOpen(!open)}
-          title={open ? "Close sidebar" : "Open sidebar"}>
-          {open ? <ChevronsLeft size={30} /> : <ChevronsRight size={30} />}
-        </Button>
-      </div>
     </div>
   )
 }