ci: run clang-tidy and attach lints to PR

Author: deckstose

.clang-tidy

@@ -0,0 +1,31 @@
+---
+Checks: >
+  -*,
+  bugprone-*,
+  clang-analyzer-*,
+  misc-*,
+  modernize-*,
+  performance-*,
+  portability-*,
+  readability-*,
+  -bugprone-assignment-in-if-condition,
+  -modernize-use-trailing-return-type,
+  -readability-braces-around-statements,
+  -readability-function-cognitive-complexity,
+  -readability-function-size,
+
+HeaderFilterRegex: '^.*\.cpp$'
+
+CheckOptions:
+  readability-identifier-length.IgnoredParameterNames: "i|x|y|z"
+  readability-identifier-length.IgnoredVariableNames: "i|x|y|z"
+  readability-identifier-naming.ClassCase: "CamelCase"
+  readability-identifier-naming.ConstexprVariableCase: "UPPER_CASE"
+  readability-identifier-naming.EnumCase: "UPPER_CASE"
+  readability-identifier-naming.FunctionCase: "lower_case"
+  readability-identifier-naming.GlobalConstexprVariableCase: "UPPER_CASE"
+  readability-identifier-naming.MemberCase: "lower_case"
+  readability-identifier-naming.MethodCase: "lower_case"
+  readability-identifier-naming.ParameterCase: "lower_case"
+  readability-identifier-naming.StructCase: "CamelCase"
+  readability-identifier-naming.VariableCase: "lower_case"

.github/workflows/cmake-linux.yml

@@ -37,6 +37,9 @@ jobs:
             version: 20
           - compiler: clang
             version: 21
+          - compiler: clang
+            version: 22
+            lint: true
           - compiler: gcc
             version: 14
     steps:
@@ -46,6 +49,12 @@ jobs:
         if: ${{ matrix.compiler == 'clang' }}
         run: wget -qO - https://apt.llvm.org/llvm.sh | sudo bash -s -- ${{ matrix.version }} all
 
+      - name: Install clang-tidy-sarif
+        if: ${{ matrix.lint }}
+        uses: taiki-e/install-action@v2
+        with:
+          tool: clang-tidy-sarif
+
       - name: Configure
         run: |
           if [[ "${{ matrix.compiler }}" == "clang" ]]; then
@@ -57,10 +66,22 @@ jobs:
             export CC=gcc-${{ matrix.version }}
             export CXX=g++-${{ matrix.version }}
           fi
-          cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug
+          cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
 
       - name: Compile
+        if: ${{ !matrix.lint }}
         run: cmake --build build --verbose
 
+      - name: Lint
+        if: ${{ matrix.lint }}
+        run: run-clang-tidy-${{ matrix.version }} -quiet -p build -hide-progress | clang-tidy-sarif > result.sarif
+
+      - name: Upload lints
+        if: ${{ matrix.lint }}
+        uses: github/codeql-action/upload-sarif@v4
+        with:
+          sarif_file: result.sarif
+
       - name: Test
+        if: ${{ !matrix.lint }}
         run: ctest --test-dir build