add test in pkg/health/health_test.go

afarbos · afarbos · commit 4d25c5a784fe · 2024-09-05T16:52:13.000-07:00
Signed-off-by: Arnaud Farbos &lt;farbos.arnaud@gmail.com&gt;
diff --git a/pkg/health/health_hpa.go b/pkg/health/health_hpa.go
@@ -147,7 +147,7 @@ func checkConditions(conditions []hpaCondition, progressingStatus *HealthStatus)
 		}
 	}
 
-	if len(conditions) == len(healthyMessages) {
+	if len(healthyMessages) > 0 {
 		return &HealthStatus{Status: HealthStatusHealthy, Message: strings.Join(healthyMessages, ",")}, nil
 	}
 
diff --git a/pkg/health/health_test.go b/pkg/health/health_test.go
@@ -81,6 +81,7 @@ func TestJob(t *testing.T) {
 func TestHPA(t *testing.T) {
 	assertAppHealth(t, "./testdata/hpa-v2-healthy.yaml", HealthStatusHealthy)
 	assertAppHealth(t, "./testdata/hpa-v2-degraded.yaml", HealthStatusDegraded)
+	assertAppHealth(t, "./testdata/hpa-v2-degraded-partially.yaml", HealthStatusDegraded)
 	assertAppHealth(t, "./testdata/hpa-v2-progressing.yaml", HealthStatusProgressing)
 	assertAppHealth(t, "./testdata/hpa-v2beta2-healthy.yaml", HealthStatusHealthy)
 	assertAppHealth(t, "./testdata/hpa-v2beta1-healthy-disabled.yaml", HealthStatusHealthy)

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ func checkConditions(conditions []hpaCondition, progressingStatus *HealthStatus)`
`147`	`147`	`}`
`148`	`148`	`}`
`149`	`149`
`150`		`- if len(conditions) == len(healthyMessages) {`
	`150`	`+ if len(healthyMessages) > 0 {`
`151`	`151`	`return &HealthStatus{Status: HealthStatusHealthy, Message: strings.Join(healthyMessages, ",")}, nil`
`152`	`152`	`}`
`153`	`153`