Make DEFAULT_REQUEUE_TIME has Missing equal to sign for kit ENV

[raufbhat-dev]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

What happened? What did you expect to happen?

make fails due to a missing "=" in the command here for kit in the below line

argo-workflows/Makefile

Line 571 in 514ea37

env DEFAULT_REQUEUE_TIME=$(DEFAULT_REQUEUE_TIME) ARGO_SECURE=$(SECURE) ALWAYS_OFFLOAD_NODE_STATUS=$(ALWAYS_OFFLOAD_NODE_STATUS) ARGO_LOGLEVEL=$(LOG_LEVEL) UPPERIO_DB_DEBUG=$(UPPERIO_DB_DEBUG) ARGO_AUTH_MODE=$(AUTH_MODE) ARGO_NAMESPACED=$(NAMESPACED) ARGO_NAMESPACE=$(KUBE_NAMESPACE) ARGO_MANAGED_NAMESPACE=$(MANAGED_NAMESPACE) ARGO_EXECUTOR_PLUGINS=$(PLUGINS) ARGO_POD_STATUS_CAPTURE_FINALIZER=$(POD_STATUS_CAPTURE_FINALIZER) ARGO_UI_SECURE=$(UI_SECURE) PROFILE=$(PROFILE) kit $(TASKS)

To Reproduce

make start

Fix

Replace kit $(TASKS) with kit=$(TASKS) in line

argo-workflows/Makefile

Line 571 in 514ea37

env DEFAULT_REQUEUE_TIME=$(DEFAULT_REQUEUE_TIME) ARGO_SECURE=$(SECURE) ALWAYS_OFFLOAD_NODE_STATUS=$(ALWAYS_OFFLOAD_NODE_STATUS) ARGO_LOGLEVEL=$(LOG_LEVEL) UPPERIO_DB_DEBUG=$(UPPERIO_DB_DEBUG) ARGO_AUTH_MODE=$(AUTH_MODE) ARGO_NAMESPACED=$(NAMESPACED) ARGO_NAMESPACE=$(KUBE_NAMESPACE) ARGO_MANAGED_NAMESPACE=$(MANAGED_NAMESPACE) ARGO_EXECUTOR_PLUGINS=$(PLUGINS) ARGO_POD_STATUS_CAPTURE_FINALIZER=$(POD_STATUS_CAPTURE_FINALIZER) ARGO_UI_SECURE=$(UI_SECURE) PROFILE=$(PROFILE) kit $(TASKS)

Screenshots

Version(s)

latest

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflow that uses private images.

GIT_COMMIT=514ea3741bd1ce151ce51eba8686ae8e7ef91105 GIT_BRANCH=main GIT_TAG=untagged GIT_TREE_STATE=dirty RELEASE_TAG=false DEV_BRANCH=false VERSION=latest
KUBECTX=none K3D=false DOCKER_PUSH=false TARGET_PLATFORM=linux/arm64
RUN_MODE=local PROFILE=minimal AUTH_MODE=hybrid SECURE=false  STATIC_FILES=false ALWAYS_OFFLOAD_NODE_STATUS=false UPPERIO_DB_DEBUG=0 LOG_LEVEL=debug NAMESPACED=true
brew tap kitproj/kit --custom-remote https://github.com/kitproj/kit
brew install kit
Warning: Not upgrading kit, the latest version is already installed
starting STATIC_FILES=false (DEV_BRANCH=false, GIT_BRANCH=main), AUTH_MODE=hybrid, RUN_MODE=local, MANAGED_NAMESPACE=argo 
⚠️️  not starting API. If you want to test the API, use 'make start API=true' to start it
⚠️  not starting UI. If you want to test the UI, run 'make start UI=true' to start it
⚠️  not starting plugins. If you want to test plugins, run 'make start PROFILE=plugins' to start it
# Check dex, minio, postgres and mysql are in hosts file
grep '127.0.0.1.*azurite' /etc/hosts
127.0.0.1       azurite
grep '127.0.0.1.*minio' /etc/hosts
127.0.0.1       minio
grep '127.0.0.1.*postgres' /etc/hosts
127.0.0.1       postgres
grep '127.0.0.1.*mysql' /etc/hosts
127.0.0.1       mysql 
env DEFAULT_REQUEUE_TIME=1s  ARGO_SECURE=false  ALWAYS_OFFLOAD_NODE_STATUS=false ARGO_LOGLEVEL=debug UPPERIO_DB_DEBUG=0 ARGO_AUTH_MODE=hybrid ARGO_NAMESPACED=true ARGO_NAMESPACE=argo  ARGO_MANAGED_NAMESPACE=argo  ARGO_EXECUTOR_PLUGINS=false ARGO_POD_STATUS_CAPTURE_FINALIZER=true ARGO_UI_SECURE=false  PROFILE=minimal kit controller
env: kit: No such file or directory
make: *** [start] Error 127

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[jswxstw]

Similar issue: #14090, which is a backwards-incompatible change with kit as #14090 (reply in thread) mentioned.

argo-workflows/Makefile

Line 541 in 7305c18

curl -fsL --retry 99 "https://github.com/kitproj/kit/releases/download/v0.1.8/kit_0.1.8_$$(uname)_$$(uname -m | sed 's/aarch64/arm64/').tar.gz" | sudo tar -C /usr/local/bin -xzf - kit

kit(v0.1.8) works fine.