Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed image references persist in Helm chart Git repository after removal from image-list #939

Open
ravikiran-talluri opened this issue Nov 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ravikiran-talluri
Copy link

Describe the bug
When using Argo CD Image Updater with Git write-back, removing an image from the argocd-image-updater.argoproj.io/image-list annotation removes it from the Argo CD Application manifest. However, references to this image persist in the .argocd-source-.yaml file committed back to the Helm chart's Git repository.

To Reproduce

  1. Annotate an Argo CD Application with the argocd-image-updater.argoproj.io/image-list annotation, including image/s.
  2. Allow the Image Updater to track and update the image.
  3. Remove the image from the image-list annotation in the Application manifest.
  4. Observe that while the image is removed from the Application manifest, references in the .argocd-source-.yaml file in the Helm chart repository are not cleaned up

Expected behavior
The Git write-back process should fully remove references to the deleted image from the .argocd-source-.yaml file, ensuring consistency between the Application manifest and the Helm chart Git repository.

Additional context
The removed image references are not properly cleaned from .argocd-source-.yaml during Git write-back, leading to potential issues with Helm chart consistency.

Version
15.1

@ravikiran-talluri ravikiran-talluri added the bug Something isn't working label Nov 21, 2024
@chengfang
Copy link
Collaborator

Does this extra image element in git repo cause any harm? Currently we pass a changeList to the writer, and since the unregistered images will not be included in that changeList, so any existing images in git repo files will not be changed. We probably should also compare each existing image in git repo file against a updateableImages list to see if any image has been unregistered since last write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants