Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken annotation "argocd-image-updater.argoproj.io/image-list" if there is more than one image in it #1008

Open
onesb23 opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@onesb23
Copy link

onesb23 commented Jan 10, 2025

Describe the bug
If multiple images are listed, only the last one is applied.

To Reproduce
An application that contains the following annotations:

metadata:
  annotations:
    argocd-image-updater.argoproj.io/image-list: myimage1,myimage2
    argocd-image-updater.argoproj.io/update-strategy: digest

According to the documentation, the corresponding kustomize should be processed and created:

spec:
  source:
    kustomize:
      images:
      - myimage1
      - myimage2

In real life, this kustomize is created:

spec:
  source:
    kustomize:
      images:
        myimage2

Expected behavior
I expect this to work correctly.

Additional context
This worked on some previous version, but rolling back to previous versions does not fix the problem.

Version
v0.15.2

Logs
In the log at each interval of synchronization with the registry there are such messages:

time="2025-01-10T16:03:34Z" level=info msg="Committing 1 parameter update(s) for application myapp" application=myapp
time="2025-01-10T16:03:35Z" level=info msg="Successfully updated the live application spec" application=myapp
time="2025-01-10T16:03:35Z" level=info msg="Processing results: applications=9 images_considered=8 images_skipped=3 images_updated=1 errors=0"
time="2025-01-10T16:04:06Z" level=info msg="Starting image update cycle, considering 8 annotated application(s) for update"
time="2025-01-10T16:04:07Z" level=info msg="Setting new image to myimage2:prod@sha256:9d2f8f8fb12f01697cd212f1fb79cca11a32d8120243a384e9cab153ad576c36" alias= application=myapp image_name=myimage2 image_tag=dummy registry="myregistry"
time="2025-01-10T16:04:07Z" level=info msg="Successfully updated image 'myimage2:prod@dummy' to 'myimage2:prod@sha256:9d2f8f8fb12f01697cd212f1fb79cca11a32d8120243a384e9cab153ad576c36', but pending spec update (dry run=false)" alias= application=myapp image_name=myimage2 image_tag=dummy registry="myregistry"
time="2025-01-10T16:04:07Z" level=info msg="Committing 1 parameter update(s) for application myapp" application=myapp
time="2025-01-10T16:04:08Z" level=info msg="Successfully updated the live application spec" application=myapp
time="2025-01-10T16:04:08Z" level=info msg="Processing results: applications=9 images_considered=8 images_skipped=3 images_updated=1 errors=0"
time="2025-01-10T16:04:38Z" level=info msg="Starting image update cycle, considering 8 annotated application(s) for update"
time="2025-01-10T16:04:39Z" level=info msg="Setting new image to myimage2:prod@sha256:9d2f8f8fb12f01697cd212f1fb79cca11a32d8120243a384e9cab153ad576c36" alias= application=myapp image_name=myimage2 image_tag=dummy registry="myregistry"
time="2025-01-10T16:04:39Z" level=info msg="Successfully updated image 'myimage2:prod@dummy' to 'myimage2:prod@sha256:9d2f8f8fb12f01697cd212f1fb79cca11a32d8120243a384e9cab153ad576c36', but pending spec update (dry run=false)" alias= application=myapp image_name=myimage2 image_tag=dummy registry="myregistry"
time="2025-01-10T16:04:40Z" level=info msg="Committing 1 parameter update(s) for application myapp" application=myapp
time="2025-01-10T16:04:41Z" level=info msg="Successfully updated the live application spec" application=myapp
time="2025-01-10T16:04:41Z" level=info msg="Processing results: applications=9 images_considered=8 images_skipped=3 images_updated=1 errors=0"
time="2025-01-10T16:05:11Z" level=info msg="Starting image update cycle, considering 8 annotated application(s) for update"
time="2025-01-10T16:05:12Z" level=info msg="Setting new image to myimage2:prod@sha256:9d2f8f8fb12f01697cd212f1fb79cca11a32d8120243a384e9cab153ad576c36" alias= application=myapp image_name=myimage2 image_tag=dummy registry="myregistry"
time="2025-01-10T16:05:12Z" level=info msg="Successfully updated image 'myimage2:prod@dummy' to 'myimage2:prod@sha256:9d2f8f8fb12f01697cd212f1fb79cca11a32d8120243a384e9cab153ad576c36', but pending spec update (dry run=false)" alias= application=myapp image_name=myimage2 image_tag=dummy registry="myregistry"

In fact, the image in the pod is not updated.
If the first or second image is specified, but only one, the pod update is successful.

@onesb23 onesb23 added the bug Something isn't working label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant